Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flag experimental-cri in e2e-node test #45707

Merged
merged 1 commit into from
May 20, 2017

Conversation

Crazykev
Copy link
Contributor

Signed-off-by: Crazykev crazykev@zju.edu.cn

What this PR does / why we need it:
This patch remove deprecated flag in node e2e test script, cause kubelet already remove this. Leave this will make kubelet start failed.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: /cc @feiskyer

Release note:

NONE

Signed-off-by: Crazykev <crazykev@zju.edu.cn>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @Crazykev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 12, 2017
@feiskyer
Copy link
Member

/assign

@feiskyer
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2017
@feiskyer
Copy link
Member

cc @yujuhong

@feiskyer
Copy link
Member

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@yujuhong
Copy link
Contributor

/lgtm

I missed this. Thanks for fixing it!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2017
@feiskyer
Copy link
Member

ping @jbeda @lavalamp for approval.

@yujuhong
Copy link
Contributor

Adding a few more folks for the approval: @dchen1107 @ixdy @fejta

@yujuhong yujuhong assigned ixdy and unassigned jbeda and lavalamp May 19, 2017
@ixdy
Copy link
Member

ixdy commented May 19, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Crazykev, ixdy, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2017
@yujuhong
Copy link
Contributor

@ixdy thanks!

@feiskyer
Copy link
Member

@k8s-bot kops aws e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 20, 2017

@Crazykev: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce f2737c4 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564)

@k8s-github-robot k8s-github-robot merged commit e2a9327 into kubernetes:master May 20, 2017
@Crazykev Crazykev deleted the cri-experimental branch May 20, 2017 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants