-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flag experimental-cri
in e2e-node test
#45707
Conversation
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Hi @Crazykev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign |
@k8s-bot ok to test |
cc @yujuhong |
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
/lgtm I missed this. Thanks for fixing it! |
Adding a few more folks for the approval: @dchen1107 @ixdy @fejta |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Crazykev, ixdy, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@ixdy thanks! |
@Crazykev: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564) |
Signed-off-by: Crazykev crazykev@zju.edu.cn
What this PR does / why we need it:
This patch remove deprecated flag in node e2e test script, cause kubelet already remove this. Leave this will make kubelet start failed.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: /cc @feiskyer
Release note: