Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #45734 #45740

Merged
merged 1 commit into from
May 22, 2017
Merged

Automated cherry pick of #45734 #45740

merged 1 commit into from
May 22, 2017

Conversation

crassirostris
Copy link

Cherry pick of #45734 on release-1.6.

#45734: Export process start time metric in fluentd-gcp

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2017
@crassirostris crassirostris added the release-note-none Denotes a PR that doesn't merit a release note. label May 12, 2017
@piosz
Copy link
Member

piosz commented May 12, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2017
@enisoc
Copy link
Member

enisoc commented May 13, 2017

On the surface, this looks like purely an enhancement. Is there some reason this is needed to fix a use case that was already promised in 1.6 but is broken?

@piosz
Copy link
Member

piosz commented May 13, 2017

see #45735 (comment)

@piosz
Copy link
Member

piosz commented May 13, 2017

Actually both PRs are about introducing monitoring of fluentd.

@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 16, 2017
@enisoc
Copy link
Member

enisoc commented May 16, 2017

@k8s-bot verify test this

@piosz
Copy link
Member

piosz commented May 16, 2017

Same question like in #45735 (comment)

@piosz piosz removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2017
@piosz
Copy link
Member

piosz commented May 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@crassirostris
Copy link
Author

@k8s-bot gce etcd3 e2e test this
@k8s-bot verify test this

@crassirostris
Copy link
Author

All failures are unrelated to logging

@crassirostris crassirostris added this to the v1.6 milestone May 22, 2017
@crassirostris crassirostris mentioned this pull request May 22, 2017
Merged
@crassirostris
Copy link
Author

@k8s-bot verify test this
@k8s-bot gce etcd3 e2e test this
@k8s-bot kops aws e2e test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2017 •
edited

@crassirostris: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins verification 0e306a0 link @k8s-bot verify test this
Jenkins GCE etcd3 e2e 0e306a0 link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crassirostris
Copy link
Author

@k8s-bot gce etcd3 e2e test this

1 similar comment
@crassirostris
Copy link
Author

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 70a5c83 into kubernetes:release-1.6 May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crassirostris @k8s-github-robot @piosz @enisoc @k8s-ci-robot