-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export process start time metric in fluentd-gcp #45734
Export process start time metric in fluentd-gcp #45734
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crassirostris, piosz
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Did you measure performance overhead? |
@piosz From this particular change? No, it should be O(1), the whole new pipeline is executed once From the monitoring? Not yet |
Automatic merge from submit-queue |
Automatic merge from submit-queue (batch tested with PRs 48139, 48042, 47645, 48054, 48003) Fix fluentd-gcp configuration to facilitate JSON parsing There's a bug in #45734, because of which each records gets additional field and google-cloud plugin thinks it's not JSON (https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/blob/master/lib/fluent/plugin/out_google_cloud.rb#L569) Fixes #48108 /cc @piosz @fgrzadkowski
For correct ingestion of cumulative metrics fluentd-gcp exposes.