Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for advanced audit #45884

Merged
merged 1 commit into from
May 17, 2017
Merged

Fix docs for advanced audit #45884

merged 1 commit into from
May 17, 2017

Conversation

CaoShuFeng
Copy link
Contributor

This change updates docs from this pr: #45862

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @CaoShuFeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2017
CaoShuFeng
CaoShuFeng commented May 16, 2017
View reviewed changes
staging/src/k8s.io/apiserver/pkg/apis/audit/types.go
@@ -48,7 +48,6 @@ type Event struct {
// Time the request reached the apiserver.
Timestamp metav1.Time
// Unique audit ID, generated for each request.
// +optional
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UID is important for identifying a single log. So I think it is not optional.

@CaoShuFeng
Copy link
Contributor Author

@timstclair
I hope my understanding is right.

@cblecker
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2017
@timstclair
Copy link

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2017
@timstclair
Copy link

/cc @sttts

@k8s-ci-robot k8s-ci-robot requested a review from sttts May 16, 2017 13:51
sttts
sttts reviewed May 16, 2017
View reviewed changes
staging/src/k8s.io/apiserver/pkg/apis/audit/types.go Outdated
// The user groups this rule applies to. If a user is considered matching
// if the are a member of any of these groups
// The user groups this rule applies to. A user is considered matching
// if it has any member of the UserGroups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is a member of any of the UserGroups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@timstclair
Copy link

/lgtm

Manually approving docs changes.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CaoShuFeng, timstclair
We suggest the following additional approver: sttts

Assign the PR to them by writing /assign @sttts in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@timstclair timstclair added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2017
@timstclair
Copy link

@k8s-bot gce etcd3 e2e test this

1 similar comment
@CaoShuFeng
Copy link
Contributor Author

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45884, 45879, 45912, 45444, 45874)

@k8s-github-robot k8s-github-robot merged commit eba01b4 into kubernetes:master May 17, 2017
@CaoShuFeng CaoShuFeng deleted the internal-audit-api branch November 6, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

Assignees

@errordeveloper errordeveloper

@hongchaodeng hongchaodeng

@timstclair timstclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@CaoShuFeng @k8s-ci-robot @cblecker @timstclair @k8s-github-robot @sttts @errordeveloper @hongchaodeng