Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for advanced audit #45884

Merged
merged 1 commit into from
May 17, 2017
Merged

Fix docs for advanced audit #45884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions staging/src/k8s.io/apiserver/pkg/apis/audit/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ type Event struct {
// Time the request reached the apiserver.
Timestamp metav1.Time
// Unique audit ID, generated for each request.
// +optional
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UID is important for identifying a single log. So I think it is not optional.

AuditID types.UID
// RequestURI is the request URI as sent by the client to a server.
RequestURI string
Expand Down Expand Up @@ -116,8 +115,8 @@ type PolicyRule struct {
// An empty list implies every user.
// +optional
Users []string
// The user groups this rule applies to. If a user is considered matching
// if the are a member of any of these groups
// The user groups this rule applies to. A user is considered matching
// if it is a member of any of the UserGroups.
// An empty list implies every user group.
// +optional
UserGroups []string
Expand Down