-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log more verbose when DisruptionController doesn't start. #46050
Conversation
To help with debugging kubernetes#45706
As a general API point, would it be better if the init function returned a |
Are you talking about |
Yeah, that conforms to an interface. |
@deads2k Sorry, got sidetracked from this PR. I don't feel strongly one way or the other. I think it's OK for the init function to just do its own logging for the moment, and it would also be OK if it returned the string. But in that case the same exact thing is going to happen: it gets glog'd. Downside is we're limited to a single line and no diagnostics around that line that might explain how we got to that part of the logic. So actually I think we're better off this way. |
I disagree, but I'm not prepared to wire new plumbing at the moment. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mml The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot gce etcd3 e2e test this |
@mml: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 44883, 46836, 46765, 46683, 46050) |
To help with debugging #45706