Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the unit test coverage of pkg/kubelet/kuberuntime #46123

Closed
yujuhong opened this issue May 19, 2017 · 5 comments
Closed

Increase the unit test coverage of pkg/kubelet/kuberuntime #46123

yujuhong opened this issue May 19, 2017 · 5 comments
Labels
area/test help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
next-candidate

Comments

@yujuhong
Copy link
Contributor

We've already seen a couple of bugs (#45977, #46121) caused by kuberuntime not populating the fields correctly. This is the type of bug that could easily be caught by unit tests.
We should improve the test coverage of this package.

/cc @feiskyer @Random-Liu
@yujuhong yujuhong added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 19, 2017
@yujuhong yujuhong added this to the next-candidate milestone May 19, 2017
@Random-Liu
Copy link
Member

Agree. And this is also why we need to add so many unit test in cri-containerd @xlgao-zju @mikebrow :)

@feiskyer
Copy link
Member

+1.

@k82cn
Copy link
Member

k82cn commented May 20, 2017

There's an issue for scheduling code coverage at #39559; I think we can open similar issue in kubelet, like this :).

@k82cn
Copy link
Member

k82cn commented May 20, 2017

xref #40780

@resouer resouer added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 24, 2017
@enxebre
Copy link
Member

enxebre commented May 26, 2017

I'm happy to work on this, I'll have a look if no one else is looking at it

@enxebre enxebre mentioned this issue May 30, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jun 3, 2017
Merge pull request #46620 from enxebre/kuberuntime-test-coverage
0bcd960 
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725)

Improving test coverage for kubelet/kuberuntime.

**What this PR does / why we need it**:
Increases test coverage for kubelet/kuberuntime 
#46123

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
#46123

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
This was referenced Jun 28, 2017
Closed
Merged
@drinktee drinktee mentioned this issue Sep 30, 2017
Closed
@drinktee drinktee mentioned this issue Oct 11, 2017
Merged
@drinktee drinktee mentioned this issue Oct 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
6 participants
@feiskyer @enxebre @resouer @Random-Liu @yujuhong @k82cn