Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ErrWatchClosed from watch.Until #46449

Merged
merged 1 commit into from
May 30, 2017
Merged

Export ErrWatchClosed from watch.Until #46449

merged 1 commit into from
May 30, 2017

Conversation

crawford
Copy link
Contributor

This is needed so that users of watch.Until may check for this
particular error instead of attempting to match the error string.

@crawford
Export ErrWatchClosed from watch.Until
505a7e9 
This is needed so that users of watch.Until may check for this
particular error instead of attempting to match the error string.

```release-note
NONE
```
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @crawford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford crawford mentioned this pull request May 25, 2017
Closed
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 25, 2017
@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, crawford

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 25, 2017
@caesarxuchao
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 25, 2017
@caesarxuchao
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 25, 2017
@crawford
Copy link
Contributor Author

crawford commented May 25, 2017 •
edited

That's a strange failure. It looks like it's failing at this line. The test results offer some log files, but that link 404s, so I'm not sure where to go from here.

EDIT:

Looks like #46446 is the same failure.

@crawford
Copy link
Contributor Author

@k8s-bot test this

@crawford
Copy link
Contributor Author

@k8s-bot pull-kubernetes-node-e2e test this

@crawford
Copy link
Contributor Author

@k8s-bot pull-kubernetes-kubemark-e2e-gce test this

@crawford
Copy link
Contributor Author

@k8s-bot pull-kubernetes-node-e2e test this

@wojtek-t wojtek-t removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 30, 2017
@wojtek-t
Copy link
Member

@k8s-bot pull-kubernetes-node-e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)

@k8s-github-robot k8s-github-robot merged commit 56e73d8 into kubernetes:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crawford @k8s-ci-robot @caesarxuchao @k8s-github-robot @wojtek-t @derekwaynecarr