Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/api-reference/*/*.html contains a timestamp #46814

Closed
thockin opened this issue Jun 2, 2017 · 3 comments · Fixed by #46857
Closed

docs/api-reference/*/*.html contains a timestamp #46814

thockin opened this issue Jun 2, 2017 · 3 comments · Fixed by #46857
Assignees
@dims
Labels
area/build-release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@thockin
Copy link
Member

thockin commented Jun 2, 2017

This means any 2 PRs that touch this fine CAN'T POSSIBLY not conflict. We should just strip the timestamp.

sed 's/Last updated ....-..-.. ..:..:.. ...//'

easy change, I hope, just needs to find the right back-and-forth in hack/lib/swagger.sh kube::swagger::gen_api_ref_docs
@thockin thockin added area/build-release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 2, 2017
@k8s-github-robot
Copy link

@thockin There are no sig labels on this issue. Please add a sig label by:
(1) mentioning a sig: @kubernetes/sig-<team-name>-misc
(2) specifying the label manually: /sig <label>

Note: method (1) will trigger a notification to the team. You can find the team list here.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 2, 2017
@cblecker
Copy link
Member

cblecker commented Jun 2, 2017

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Jun 2, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 2, 2017
@dims
Copy link
Member

dims commented Jun 2, 2017

/assign

@dims dims mentioned this issue Jun 2, 2017
Merged
dims added a commit to dims/kubernetes that referenced this issue Jun 20, 2017
@dims
Remove timestamps from docs/api-reference/*/*.html
5b3c366 
If there are 2 or more PR(s) in the queue, they will end up with
conflicts (and rechecks). So let us remove the timestamp entirely
when we generate the files.

Fixes kubernetes#46814
k8s-github-robot pushed a commit that referenced this issue Jun 20, 2017
Merge pull request #46857 from dims/remove-timestamps-from-api-reference
46fe7f0 
Automatic merge from submit-queue

Remove timestamps from docs/api-reference/*/*.html

**What this PR does / why we need it**:

If there are 2 or more PR(s) in the queue, they will end up with
conflicts (and rechecks). So let us remove the timestamp entirely
when we generate the files.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

Fixes #46814

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dims dims

Labels
area/build-release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove timestamps from docs/api-reference/*/*.html dims/kubernetes
5 participants
@dims @cblecker @thockin @k8s-github-robot @k8s-ci-robot