Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstructured.OwnerReferences are not round-tripped properly #46817

Closed
ash2k opened this issue Jun 2, 2017 · 2 comments
Closed

Unstructured.OwnerReferences are not round-tripped properly #46817

ash2k opened this issue Jun 2, 2017 · 2 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
v1.7

Comments

@ash2k
Copy link
Member

ash2k commented Jun 2, 2017

Kubernetes version
Code from master.

What happened:
Unstructured.GetOwnerReferences() does not return Controller and BlockOwnerDeletion fields after they are set to non-nil values using Unstructured.SetOwnerReferences().

How to reproduce it (as minimally and precisely as possible):
See PR #46683
@ash2k ash2k mentioned this issue Jun 2, 2017
Merged
@ash2k
Copy link
Member Author

ash2k commented Jun 2, 2017

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 2, 2017
@deads2k deads2k added this to the v1.7 milestone Jun 2, 2017
@deads2k
Copy link
Contributor

deads2k commented Jun 2, 2017

This is a good find and I don't think I saw the notification come through :(

k8s-github-robot pushed a commit that referenced this issue Jun 6, 2017
Merge pull request #46683 from atlassian/fix-untructured-owner-refere…
61cd3fc 
…nces

Automatic merge from submit-queue (batch tested with PRs 44883, 46836, 46765, 46683, 46050)

Fix round-trip of Unstructured.OwnerReferences

**What this PR does / why we need it**:
Previously `setOwnerReference()` was storing pointers but `extractOwnerReference()` is expecting pointer fields as plain values so it cannot read those pointers. And hence you cannot read what you've just stored.

**Which issue this PR fixes**
#46817

**Special notes for your reviewer**:
This is similar to #43346.

**Release note**:
```release-note
NONE
```
mrIncompetent pushed a commit to kubermatic/kubernetes that referenced this issue Jun 6, 2017
@ash2k
Fix round-trip of Unstructured.OwnerReferences
f19e969 
Previously setOwnerReference was storing pointers but
extractOwnerReference is expecting pointer fields as plain values.
Fixes kubernetes#46817
@ash2k ash2k mentioned this issue Jun 15, 2017
Merged
@ash2k ash2k mentioned this issue Nov 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
3 participants
@ash2k @deads2k @k8s-ci-robot