Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ResourceConsumer.CleanUp to properly clean up non-replication-controller resources and pods #46833

Merged
merged 1 commit into from Jun 7, 2017
Merged

Fixed ResourceConsumer.CleanUp to properly clean up non-replication-controller resources and pods #46833

merged 1 commit into from Jun 7, 2017

Conversation

wasylkowski
Copy link

What this PR does / why we need it: Without this fix CleanUp does not remove non-replication-controller resources and pods. This leads to pollution that in some cases inadvertently affects what is happening in AfterEachs before the namespace gets deleted.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @wasylkowski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 2, 2017
@jszczepkowski
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2017

@k8s-bot ok to test

@wasylkowski
Copy link
Author

/assign @wojtek-t

@wasylkowski
Copy link
Author

@k8s-bot pull-kubernetes-e2e-kops-aws test this

wojtek-t
wojtek-t reviewed Jun 2, 2017
View reviewed changes
test/e2e/common/autoscaling_utils.go
KindRC = "replicationController"
KindDeployment = "deployment"
KindReplicaSet = "replicaset"
KindRC = "ReplicationController"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it work before?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked because during resource creation these constants were only used in a switch to go to the correct case, which then did not rely on them for choosing the proper API call. This is no longer the case, because now I use api.Kind for deletion.

@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@wasylkowski
Copy link
Author

Added missing BUILD file changes. Restarting failed tests.

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-verify test this
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 2, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2017
@wasylkowski
Copy link
Author

Ref: #46847

@wasylkowski
Copy link
Author

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@wasylkowski
Copy link
Author

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-verify test this

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@wasylkowski
Copy link
Author

Rerunning flaky tests

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-verify test this

@wojtek-t
Copy link
Member

wojtek-t commented Jun 6, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wasylkowski, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 6, 2017

Adding milestone, since this is test fix.

@wojtek-t wojtek-t added this to the v1.7 milestone Jun 6, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)

@k8s-github-robot k8s-github-robot merged commit 07e4cca into kubernetes:master Jun 7, 2017
@smarterclayton
Copy link
Contributor

This looks like the last commit that touched autoscaling utils, which is failing in the serial runs with:

I0607 01:09:38.349] �[91m�[1m•! Panic [32.767 seconds]�[0m
I0607 01:09:38.349] [k8s.io] Initializers
I0607 01:09:38.349] �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:617�[0m
I0607 01:09:38.349]   �[91m�[1mshould dynamically register and apply initializers to pods [Serial] [It]�[0m
I0607 01:09:38.349]   �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/extension/initializers.go:206�[0m
I0607 01:09:38.349] 
I0607 01:09:38.350]   �[91m�[1mTest Panicked�[0m
I0607 01:09:38.350]   �[91mruntime error: invalid memory address or nil pointer dereference�[0m
I0607 01:09:38.350]   /usr/local/go/src/runtime/asm_amd64.s:514
I0607 01:09:38.350] 
I0607 01:09:38.350]   �[91mFull Stack Trace�[0m
I0607 01:09:38.350]   	/usr/local/go/src/runtime/panic.go:489 +0x2cf
I0607 01:09:38.350]   k8s.io/kubernetes/test/e2e/common.(*ResourceConsumer).sendConsumeCPURequest.func1(0x2ef4ce0, 0xc421f65140, 0xc42114fd3f)
I0607 01:09:38.351]   	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/common/autoscaling_utils.go:231 +0x5f

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-serial/1173

Is this a bug with how the test client is initialized?

@smarterclayton smarterclayton mentioned this pull request Jun 7, 2017
Closed
@smarterclayton
Copy link
Contributor

spawned #47127

@wasylkowski
Copy link
Author

As I mentioned in #47127, this PR is unrelated to the failure. Reverting it does not make the failure go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

Assignees

@rmmh rmmh

@foxish foxish

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@wasylkowski @k8s-ci-robot @jszczepkowski @wojtek-t @k8s-github-robot @smarterclayton @rmmh @foxish @wasylkowski-a