Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate openapi for 1.8 #46863

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Regenerate openapi for 1.8 #46863

merged 1 commit into from
Jun 2, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 2, 2017 •
edited

With the 1.7 branch cut and a new tag in master, the generated openapi spec validation is failing. This fixes it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2017
@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2017

cc @k8s-oncall

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 2, 2017
@liggitt liggitt added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. queue/fix and removed release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2017
@liggitt liggitt added this to the v1.7 milestone Jun 2, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 2, 2017
@shashidharatd
Copy link

/lgtm
Thanks !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liggitt, shashidharatd
We suggest the following additional approver: jbeda

Assign the PR to them by writing /assign @jbeda in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 2, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jun 2, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 2, 2017 •
edited

@liggitt: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 24c50a7 link @k8s-bot pull-kubernetes-e2e-kops-aws test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2017

kops failure is separate known issue #46853

@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2017

@k8s-oncall all green except known kops issue, recommend a force-merge

@smarterclayton
Copy link
Contributor

I also recommend force merge, will do so at 1pm EDT

@mikedanese mikedanese merged commit f2362e9 into kubernetes:master Jun 2, 2017
@mikedanese mikedanese mentioned this pull request Jun 2, 2017
Closed
@pipejakob pipejakob mentioned this pull request Jun 2, 2017
Merged
@mikedanese mikedanese mentioned this pull request Jun 2, 2017
Closed
@liggitt liggitt deleted the regen1.8 branch June 3, 2017 15:02
@nikhiljindal nikhiljindal mentioned this pull request Jun 26, 2017
Closed
@CaoShuFeng
Copy link
Contributor

CaoShuFeng commented Sep 2, 2017 •
edited

This shows up again:
#51851

@jdumars jdumars mentioned this pull request Sep 2, 2017
Merged
@xiangpengzhao xiangpengzhao mentioned this pull request Nov 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@shashidharatd shashidharatd

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@liggitt @shashidharatd @k8s-github-robot @k8s-ci-robot @smarterclayton @CaoShuFeng @jbeda @mikedanese