Update Azure SDK. #47140
Merged
Update Azure SDK. #47140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
ugh, something is broken here... |
k8s-github-robot
added
size/XXL
brendandburns
force-pushed
the
godep
branch
2 times, most recently
from
34350dd
to
66e9eb5
Compare
brendandburns
added
release-note-none
brendandburns
force-pushed
the
godep
branch
7 times, most recently
from
eca63cb
to
5c6bc46
Compare
|
/retest |
1 similar comment
|
/retest |
|
@jbeda this is good to go (once a flaky tests passes) can I get an LGTM? |
brendandburns
force-pushed
the
godep
branch
2 times, most recently
from
995c14f
to
c186419
Compare
|
@rootfs @colemickens @jbeda This is ready to go (again), can I get an LGTM? There is nothing here except SDK updates and necessary small changes to the azure client code. Thanks! |
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
lgtm
|
/lgtm thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, jbeda, rootfs Associated issue requirement bypassed by: brendandburns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 48672, 47140, 48709, 48786, 48757) |
|
I think this may have broken the crossbuild. From https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-cross-build/2320/: |
|
looks like moby/moby@fab67ab made it into docker v1.12, but we vendor v1.11. :\ |
This was referenced Jul 13, 2017
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 17, 2017
Automatic merge from submit-queue (batch tested with PRs 48997, 48595, 48898, 48711, 48972) Revert "Use go-ansiterm version matching docker/pkg/term/windows v1.11" This reverts commit 72044a1. **What this PR does / why we need it**: earlier this week, #47140 updated the vendored azure dependencies, which broke the windows build because the docker dependencies were too old. #48933 was merged, which reverted part of #47140 and fixed the build, but then #48308, which updated the vendored docker dependencies, broke the windows build again. By reverting #48933, we should get back to a working build, I hope. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48887 **Release note**: ```release-note NONE ``` /release-note-none /test pull-kubernetes-cross /assign @brendandburns cc @karataliu @yguo0905 @yujuhong @dchen1107
seanknox
pushed a commit
to seanknox/kubernetes
that referenced
this pull request
Jul 18, 2017
wojtek-t
added
the
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the Azure SDK to pick up new APIs.