Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start etcd in integration tests with TestMain #47090

Merged
merged 3 commits into from
Jul 14, 2017
Merged

Start etcd in integration tests with TestMain #47090

merged 3 commits into from
Jul 14, 2017

Conversation

mikedanese
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jun 6, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 6, 2017
spxtr
spxtr reviewed Jun 6, 2017
View reviewed changes
test/integration/framework/BUILD
"master_utils.go",
"perf_utils.go",
"serializer.go",
],
data = [
"@com_coreos_etcd//:etcd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@spxtr
Copy link
Contributor

spxtr commented Jun 7, 2017

Why add make bazel-test-integration, if they can be run as totally normal unit tests? It seems like test size is the appropriate delimiter.

This is super awesome, btw.

@mikedanese
Copy link
Member Author

@spxtr It's going to make make test run much longer is that OK do you think?

@mikedanese mikedanese force-pushed the bazel-integration branch 8 times, most recently from a028cdb to 1a6a5f5 Compare June 9, 2017 16:53
@spxtr
Copy link
Contributor

spxtr commented Jun 12, 2017

You're so close!

@spxtr
Copy link
Contributor

spxtr commented Jun 15, 2017

/retest

@spxtr
Copy link
Contributor

spxtr commented Jun 15, 2017

This looks super awesome to me. I'm fine with make test running integration tests too, but we can leave it as-is for now.

@spxtr
Copy link
Contributor

spxtr commented Jun 15, 2017

/approve no-issue
@ixdy want to LGTM?

@mikedanese mikedanese added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2017
@mikedanese
Copy link
Member Author

/retest

ixdy
ixdy reviewed Jun 16, 2017
View reviewed changes
Copy link
Member

@ixdy ixdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this create a new etcd instance for each package?

build/root/WORKSPACE
@@ -12,6 +12,15 @@ http_archive(
urls = ["https://github.com/kubernetes/repo-infra/archive/9dedd5f4093884c133ad5ea73695b28338b954ab.tar.gz"],
)

ETCD_VERSION = "3.0.17"

new_http_archive(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the sha256 digest?

test/integration/framework/etcd.go Outdated

info, err := os.Stat(etcdPath)
if os.IsNotExist(err) {
glog.Fatalf("Cannot run test without etcd. Please install with ./hack/install-etcd.sh: looked in path %q", etcdPath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this check? won't install-etcd.sh not help with bazel?

test/integration/framework/etcd.go Outdated
}

// return the EtcdURL
func GetEtcdURLFromEnv() string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of this function is somewhat incorrect now, but I guess we can cleanup later.

@spxtr
Copy link
Contributor

spxtr commented Jun 16, 2017

does this create a new etcd instance for each package?

Yes, but it doesn't slow things down significantly according to Mike.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2017
@ixdy
Copy link
Member

ixdy commented Jul 13, 2017

I think #47140 broke the crossbuild.

@mikedanese
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 8744db4 link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ixdy
Copy link
Member

ixdy commented Jul 13, 2017

I opened an issue on cross-build for better visibility: #48887

@mikedanese
Copy link
Member Author

@ixdy is this good to go? I addressed your comments

@ixdy
Copy link
Member

ixdy commented Jul 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ixdy, mikedanese, spxtr
We suggest the following additional approver: jregan

Assign the PR to them by writing /assign @jregan in a comment when ready.

Associated issue: 47089

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48572, 48838, 48931, 48783, 47090)

k8s-github-robot pushed a commit that referenced this pull request Jul 14, 2017
Merge pull request #47090 from mikedanese/bazel-integration
87445c5 
Automatic merge from submit-queue (batch tested with PRs 48572, 48838, 48931, 48783, 47090)

Start etcd in integration tests with TestMain

#47089
@k8s-github-robot k8s-github-robot merged commit 87445c5 into kubernetes:master Jul 14, 2017
@mikedanese mikedanese deleted the bazel-integration branch July 14, 2017 17:55
@xiangpengzhao xiangpengzhao mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spxtr spxtr spxtr left review comments

@ixdy ixdy ixdy left review comments

Assignees

@spxtr spxtr

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikedanese @spxtr @ixdy @k8s-ci-robot @k8s-github-robot