Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double ns deletion timeout #47479

Merged
merged 1 commit into from Jun 14, 2017
Merged

double ns deletion timeout #47479

merged 1 commit into from Jun 14, 2017

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jun 14, 2017 •
edited

Overnight for monitoring.

Ref #47135

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikedanese

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 14, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 14, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2017
@mikedanese mikedanese assigned mikedanese and unassigned fejta and smarterclayton Jun 14, 2017
liggitt
liggitt reviewed Jun 14, 2017
View reviewed changes
test/e2e/framework/framework.go Outdated
@@ -52,7 +52,7 @@ import (

const (
maxKubectlExecRetries = 5
DefaultNamespaceDeletionTimeout = 5 * time.Minute
DefaultNamespaceDeletionTimeout = 10 * time.Minute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment referring to this PR and the associated issue and indicate it should be returned to 5 minutes once the issue is resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2017
@mikedanese mikedanese added this to the v1.7 milestone Jun 14, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47073, 47457, 47479)

@k8s-github-robot k8s-github-robot merged commit ae8258d into kubernetes:master Jun 14, 2017
@liggitt
Copy link
Member

liggitt commented Jun 14, 2017 •
edited

this didn't seem to help overall test failure rates based on https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-etcd3

@dchen1107 dchen1107 mentioned this pull request Jun 14, 2017
Closed
bowei added a commit to bowei/kubernetes that referenced this pull request Jun 16, 2017
@bowei
Fix hardcoded CIDR in the validation_test
1ed4afc 
The ideal fix is to not hardcode these values.

fixes kubernetes#47479
@bowei bowei mentioned this pull request Jun 16, 2017
Merged
bowei added a commit to bowei/kubernetes that referenced this pull request Jun 19, 2017
@bowei
Fix hardcoded CIDR in the validation_test
15c5509 
The ideal fix is to not hardcode these values.

fixes kubernetes#47479

Cherrypick of 1ed4afc from 1.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikedanese @k8s-github-robot @liggitt @fejta @smarterclayton @k8s-ci-robot