Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded CIDR in the validation_test #47631

Merged
merged 1 commit into from Jun 16, 2017
Merged

Conversation

bowei
Copy link
Member

@bowei bowei commented Jun 16, 2017

The ideal fix is to not hardcode these values.

fixes #47479

none

The ideal fix is to not hardcode these values.

fixes kubernetes#47479
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 16, 2017
@k8s-ci-robot k8s-ci-robot assigned dnardo and unassigned thockin and wojtek-t Jun 16, 2017
@dnardo
Copy link
Contributor

dnardo commented Jun 16, 2017

I actually had a fix for this and was just waiting for the e2e tests to finish, but it looks like you beat me to it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@dnardo
Copy link
Contributor

dnardo commented Jun 16, 2017

I think this fixes #47379
not pr/47379 - link goes to the pr

@cmluciano
Copy link

/lgtm

/retest

flaky test failure

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei, cmluciano, dnardo
We suggest the following additional approver: erictune

Assign the PR to them by writing /assign @erictune in a comment when ready.

Associated issue: 47479

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cmluciano
Copy link

@bowei @dnardo This should be merged into 1.7 right?

@dnardo
Copy link
Contributor

dnardo commented Jun 16, 2017

@cmluciano yes

@cmluciano cmluciano added this to the v1.7 milestone Jun 16, 2017
@cmluciano cmluciano added approved-for-milestone kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jun 16, 2017
@cmluciano
Copy link

@lavalamp @erictune @smarterclayton Can we get an approval from the pkg/api side?

@bowei
Copy link
Member Author

bowei commented Jun 16, 2017

@dchen1107 @kubernetes/kubernetes-release-managers needs approval

@dchen1107
Copy link
Member

I believe this is for fixing #47379, not #47479

@dchen1107
Copy link
Member

I am going to manually merging this one to get better data for upgrade tests. Currently the upgrade test is failed due this issue.

cc/ @kubernetes/kubernetes-release-managers @pwittrock @monopole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants