New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardcoded CIDR in the validation_test #47631
Conversation
The ideal fix is to not hardcode these values. fixes kubernetes#47479
I actually had a fix for this and was just waiting for the e2e tests to finish, but it looks like you beat me to it. /lgtm |
I think this fixes #47379 |
/lgtm /retest flaky test failure |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bowei, cmluciano, dnardo Assign the PR to them by writing Associated issue: 47479 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@cmluciano yes |
@lavalamp @erictune @smarterclayton Can we get an approval from the pkg/api side? |
@dchen1107 @kubernetes/kubernetes-release-managers needs approval |
I am going to manually merging this one to get better data for upgrade tests. Currently the upgrade test is failed due this issue. cc/ @kubernetes/kubernetes-release-managers @pwittrock @monopole |
The ideal fix is to not hardcode these values.
fixes #47479