Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CRI package name to runtime. #47818

Merged
merged 1 commit into from Jun 21, 2017
Merged

Change CRI package name to runtime. #47818

merged 1 commit into from Jun 21, 2017

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jun 20, 2017 •
edited

Fixes #47814.

@yujuhong @feiskyer /cc @kubernetes/sig-node-bugs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2017
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 20, 2017
@Random-Liu Random-Liu added this to the v1.7 milestone Jun 20, 2017
@Random-Liu
Copy link
Member Author

Random-Liu commented Jun 20, 2017 •
edited

@dchen1107 This fixes #47012 and #47814.

#47113 didn't actually fix it.

This was referenced Jun 20, 2017
Merged
Closed
@yujuhong
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2017
@Random-Liu Random-Liu mentioned this pull request Jun 20, 2017
Closed
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, yujuhong

Associated issue: 47814

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 20, 2017
@feiskyer
Copy link
Member

LGTM

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45268, 47573, 47632, 47818)

@k8s-github-robot k8s-github-robot merged commit 8316bbc into kubernetes:master Jun 21, 2017
@feiskyer feiskyer mentioned this pull request Jun 21, 2017
Closed
@Random-Liu Random-Liu deleted the change-cri-package-name branch June 22, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Random-Liu @yujuhong @k8s-github-robot @feiskyer @k8s-ci-robot