Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet: rename cri package name to pkg/kubelet/apis/cri/v1alpha1/runtime #47113

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Kubelet: rename cri package name to pkg/kubelet/apis/cri/v1alpha1/runtime #47113

merged 3 commits into from
Jun 9, 2017

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Jun 7, 2017 •
edited

What this PR does / why we need it:

We have moved CRI from api/v1alpha1/runtime to apis/cri/v1alpha1, which changed the package name of CRI. This would cause a significant problem: old-versioned runtime (based on CRI in v1.6) doesn't work with latest kubelet v1.7, and vice versa.

This PR renames cri package name to pkg/kubelet/apis/cri/v1alpha1/runtime for fixing the problem.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #47012

Special notes for your reviewer:

Should be included in v1.7.

Release note:

CRI has been moved to package `pkg/kubelet/apis/cri/v1alpha1/runtime`.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 7, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Jun 7, 2017

/assign @yujuhong

cc/ @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 7, 2017
@dims
Copy link
Member

dims commented Jun 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2017
@yujuhong yujuhong assigned mtaufen and unassigned ncdc Jun 7, 2017
@resouer
Copy link
Contributor

resouer commented Jun 8, 2017 •
edited

This requires /hack approve, so let's: /assign @lavalamp

@mtaufen
Copy link
Contributor

mtaufen commented Jun 8, 2017

/lgtm

@mtaufen
Copy link
Contributor

mtaufen commented Jun 8, 2017

Are we trying to get this into 1.7?

@yujuhong
Copy link
Contributor

yujuhong commented Jun 8, 2017

Are we trying to get this into 1.7?

Yes.

@yujuhong yujuhong assigned dchen1107 and unassigned lavalamp Jun 8, 2017
@yujuhong
Copy link
Contributor

yujuhong commented Jun 8, 2017

/approve

@feiskyer
Copy link
Member Author

feiskyer commented Jun 8, 2017

@yujuhong Could you help to set the milestone to v1.7?

@feiskyer
Copy link
Member Author

feiskyer commented Jun 8, 2017

/assign @Random-Liu

ping @lavalamp @Random-Liu for approval.

@resouer resouer added this to the v1.7 milestone Jun 9, 2017
@dchen1107
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Jun 9, 2017

@dchen1107 @yujuhong Rebased. PTAL.

@feiskyer feiskyer mentioned this pull request Jun 9, 2017
Closed
@dims
Copy link
Member

dims commented Jun 9, 2017

/unassign

@yujuhong
Copy link
Contributor

yujuhong commented Jun 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dims, feiskyer, mtaufen, yujuhong

Associated issue: 47012

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f754788 into kubernetes:master Jun 9, 2017
@feiskyer feiskyer deleted the cri branch June 9, 2017 23:18
@feiskyer feiskyer mentioned this pull request Jun 12, 2017
Closed
@Random-Liu Random-Liu mentioned this pull request Jun 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtaufen mtaufen

@Random-Liu Random-Liu

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

incompatible change of kubelet CRI package