Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a slightly more verbose error when "go get" fails. #48292

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Return a slightly more verbose error when "go get" fails. #48292

merged 2 commits into from
Jul 6, 2017

Conversation

mml
Copy link
Contributor

@mml mml commented Jun 29, 2017

No description provided.

@mml mml assigned rmmh Jun 29, 2017
@mml mml added priority/P3 release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2017
rmmh
rmmh reviewed Jun 29, 2017
View reviewed changes
hack/e2e.go Outdated
@@ -145,7 +145,7 @@ func (t tester) getKubetest(get bool, old time.Duration) (string, error) {
}
log.Print("Updating kubetest binary...")
if err = t.wait("go", "get", "-u", "k8s.io/test-infra/kubetest"); err != nil {
return "", err // Could not upgrade
return "", fmt.Errorf("go get -u k8s.io/test-infra/kubetest: %v"), err // Could not upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could put command in a []string to avoid a future change making the error message misleading, but it's probably fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think err needs to move inside of the fmt.Errorf()

@rmmh
Copy link
Contributor

rmmh commented Jun 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

/assign ixdy

@cblecker
Copy link
Member

@mml:

W0629 17:18:30.637] # k8s.io/kubernetes/hack
W0629 17:18:30.638] hack/e2e.go:148: type string is not an expression
W0629 17:18:30.638] hack/e2e.go:148: not enough arguments in call to t.wait
W0629 17:18:30.638] 	have (<T>...)
W0629 17:18:30.638] 	want (string, ...string)

@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

@cblecker thanks... this one actually compiles and runs.

@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

/assign ixdy

@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

@k8s-bot oh i'm missing a stupid @ sign... you could at least say so!

@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

/assign @ixdy

This was referenced Jun 30, 2017
Closed
Closed
@ixdy
Copy link
Member

ixdy commented Jun 30, 2017

/lgtm

actually fixing this so it DTRT if you had test-infra checked out would be even better, though I'm not sure how you'd do that. go install instead of go get, maybe?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@ixdy
Copy link
Member

ixdy commented Jun 30, 2017

(OTOH, that would cause you to install an old version of kubetest if your test-infra workspace was out of date. hm.)

@ixdy
Copy link
Member

ixdy commented Jun 30, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2017
@rmmh rmmh mentioned this pull request Jun 30, 2017
Merged
@mml
Copy link
Contributor Author

mml commented Jun 30, 2017

OMG that test.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2017
@rmmh
Copy link
Contributor

rmmh commented Jun 30, 2017

golint wants s/eu_verbose/euVerbose/.

@mml
Copy link
Contributor Author

mml commented Jul 5, 2017

golint wants s/eu_verbose/euVerbose/.

@rmmh fixed PTAL

@rmmh
Copy link
Contributor

rmmh commented Jul 5, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mml, rmmh

Associated issue requirement bypassed by: ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48292, 48121)

@k8s-github-robot k8s-github-robot merged commit c0c3fe0 into kubernetes:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmmh rmmh rmmh left review comments

@cblecker cblecker cblecker left review comments

Assignees

@rmmh rmmh

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mml @rmmh @cblecker @ixdy @k8s-github-robot @k8s-ci-robot