Add a node upgrade test for etcd statefulset with a PDB. #48374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mml
added
priority/P3
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
size/L
|
/retest |
|
cc @bdbauer |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
for approval /assign @lavalamp |
|
/assign lavalamp |
|
/assign @lavalamp (third times a charm?) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, maisem, mml Associated issue: 38336 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest
…On Thu, Jul 6, 2017 at 4:10 PM, k8s-ci-robot ***@***.***> wrote:
@mml <https://github.com/mml>: The following test *failed*, say /retest
to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce 5bbb163
<5bbb163>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48374/pull-kubernetes-kubemark-e2e-gce/38126/> /test
pull-kubernetes-kubemark-e2e-gce
Full PR test history <https://k8s-gubernator.appspot.com/pr/48374>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/mml>. Please help us
cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48374 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMK6Cu5UHPC8ligM5sGyX3cfuSXj9eks5sLWlkgaJpZM4OLIwS>
.
|
|
AFAICT the test passed, but we failed to grab some logfiles after the fact.
:-(
/retest
…On Thu, Jul 6, 2017 at 5:34 PM, k8s-ci-robot ***@***.***> wrote:
@mml <https://github.com/mml>: The following test *failed*, say /retest
to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce 5bbb163
<5bbb163>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48374/pull-kubernetes-kubemark-e2e-gce/38147/> /test
pull-kubernetes-kubemark-e2e-gce
Full PR test history <https://k8s-gubernator.appspot.com/pr/48374>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/mml>. Please help us
cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48374 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMK1dtkwuWqikbNivu4VRvujsqmkScks5sLX0CgaJpZM4OLIwS>
.
|
|
Automatic merge from submit-queue (batch tested with PRs 48374, 48524, 48519, 42548, 48615) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #38336