Make the cluster-id tag required for aws #48954
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
k8s-ci-robot
added
kind/feature
|
cc #48504 . When an AWS cluster is not tagged, volumes may get provisioned in zones outside cluster and they'll be unexpectedly unusable by the user |
|
I am working on this |
rrati
pushed a commit
to rrati/kubernetes
that referenced
this issue
Jul 19, 2017
rrati
pushed a commit
to rrati/kubernetes
that referenced
this issue
Jul 19, 2017
rrati
pushed a commit
to rrati/kubernetes
that referenced
this issue
Aug 10, 2017
k8s-github-robot
pushed a commit
that referenced
this issue
Aug 10, 2017
Automatic merge from submit-queue Make ClusterID required for AWS. **What this PR does / why we need it**: Makes ClusterID required for AWS and provides a flag to run in un-tagged mode fixes #48954 **Release note**: ```release-note A cluster using the AWS cloud provider will need to label existing nodes and resources with a ClusterID or the kube-controller-manager will not start. To run without a ClusterID pass --allow-untagged-cloud=true to the kube-controller-manager on startup. ```
dims
pushed a commit
to dims/kubernetes
that referenced
this issue
Feb 8, 2018
dims
pushed a commit
to dims/kubernetes
that referenced
this issue
Feb 8, 2018
Automatic merge from submit-queue Make ClusterID required for AWS. **What this PR does / why we need it**: Makes ClusterID required for AWS and provides a flag to run in un-tagged mode fixes kubernetes#48954 **Release note**: ```release-note A cluster using the AWS cloud provider will need to label existing nodes and resources with a ClusterID or the kube-controller-manager will not start. To run without a ClusterID pass --allow-untagged-cloud=true to the kube-controller-manager on startup. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind feature
A Kubernetes cluster in AWS can run without the cluster-id being set on nodes, but odd issues can pop up. If multiple clusters exist in the same AZ under the same user account, then things can get even more interesting. We should make tagging the AWS instances required and fail to start the cluster if they are not set. If either KubernetesCluster or kubernetes.io/cluster is set then the cluster will start, otherwise print an error indicating the instances need to be tagged.
There should be a flag to support legacy behavior (ie no labeling needed). This flag should be on one or more of:
kube-apiserver
kube-controller-manager
cloud-controller-manager
@kubernetes/sig-aws-misc @justinsb
The text was updated successfully, but these errors were encountered: