Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go-ansiterm version matching docker/pkg/term/windows v1.11 #49204

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Use go-ansiterm version matching docker/pkg/term/windows v1.11 #49204

merged 1 commit into from
Jul 19, 2017

Conversation

brendandburns
Copy link
Contributor

Fixes the broken build.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jul 19, 2017
@wojtek-t wojtek-t assigned wojtek-t and unassigned smarterclayton and thockin Jul 19, 2017
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 19, 2017
@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Jul 19, 2017
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [brendandburns,wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2017
@wojtek-t wojtek-t mentioned this pull request Jul 19, 2017
Closed
@brendandburns
Copy link
Contributor Author

/test pull-kubernetes-cross

@wojtek-t
Copy link
Member

@brendandburns - may I ask you to manually merge this once tests will be green?

@wojtek-t
Copy link
Member

OK - all the tests except from "cross" have already passed (cross it still running).
So I'm manually merging this PR now to (hopefully) have the release branch healthy ASAP.

@wojtek-t wojtek-t merged commit e7bb571 into kubernetes:release-1.7 Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@brendandburns @wojtek-t @k8s-github-robot @smarterclayton @thockin @k8s-ci-robot @karataliu