DefaultRESTMapper does not work for custom resources CRD #49948
Assignees
Labels
area/custom-resources
kind/bug
Categorizes issue or PR as related to a bug.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
Comments
k8s-ci-robot
added
kind/bug
|
cc @kubernetes/sig-api-machinery-bugs @deads2k |
|
opened #50012 |
|
I somehow missed this issue and independently re-discovered it while root causing #50022. Oops! Thanks! |
k8s-github-robot
pushed a commit
that referenced
this issue
Sep 15, 2017
Automatic merge from submit-queue use specified discovery information if possible Fixes #49948 This uses the available discovery information if available, but it seems we never updated "normal" resources to show the singular name, so its often not available. I've left this code compatible. @enisoc @ash2k @kubernetes/sig-api-machinery-misc ```release-note custom resources that use unconventional pluralization now work properly with kubectl and garbage collection ```
sttts
pushed a commit
to sttts/apimachinery
that referenced
this issue
Sep 22, 2017
Automatic merge from submit-queue use specified discovery information if possible Fixes kubernetes/kubernetes#49948 This uses the available discovery information if available, but it seems we never updated "normal" resources to show the singular name, so its often not available. I've left this code compatible. @enisoc @ash2k @kubernetes/sig-api-machinery-misc ```release-note custom resources that use unconventional pluralization now work properly with kubectl and garbage collection ``` Kubernetes-commit: e190f391129260527c119fe319216212c916ae5d
sttts
pushed a commit
to sttts/client-go
that referenced
this issue
Sep 22, 2017
Automatic merge from submit-queue use specified discovery information if possible Fixes kubernetes/kubernetes#49948 This uses the available discovery information if available, but it seems we never updated "normal" resources to show the singular name, so its often not available. I've left this code compatible. @enisoc @ash2k @kubernetes/sig-api-machinery-misc ```release-note custom resources that use unconventional pluralization now work properly with kubectl and garbage collection ``` Kubernetes-commit: e190f391129260527c119fe319216212c916ae5d
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this issue
Sep 20, 2022
Automatic merge from submit-queue use specified discovery information if possible Fixes kubernetes/kubernetes#49948 This uses the available discovery information if available, but it seems we never updated "normal" resources to show the singular name, so its often not available. I've left this code compatible. @enisoc @ash2k @kubernetes/sig-api-machinery-misc ```release-note custom resources that use unconventional pluralization now work properly with kubectl and garbage collection ``` Kubernetes-commit: e190f391129260527c119fe319216212c916ae5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
DefaultRESTMapper.Add()usesUnsafeGuessKindToResource()instead of usingpluralfield returned by discovery.What you expected to happen:
Rest mapper should return correct plural form in the "resource" field of
RESTMapping.How to reproduce it (as minimally and precisely as possible):
Create a CRD where plural != lowercase kind+"s" e.g. plural is "bla1" and kind is "Blax".
On a discovery rest mapper try to call
RESTMapping()with the group/kind of the CR.It will return something like "blaxs".
I wonder how GC works in #47665. Isn't it affected by this issue? @ironcladlou
Environment:
I use 1.7 branch of client-go but looks like k8s master does not have any changes to
DefaultRESTMapperso the bug is there too./kind bug
/sig api-machinery
/area third-party-resource
The text was updated successfully, but these errors were encountered: