Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /bindings to /binding pod subresource #5000

Closed
bgrant0607 opened this issue Mar 3, 2015 · 7 comments · Fixed by #5054
Closed

Change /bindings to /binding pod subresource #5000

bgrant0607 opened this issue Mar 3, 2015 · 7 comments · Fixed by #5054
Assignees
Labels
area/api Indicates an issue on api area. area/usability priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@bgrant0607
Copy link
Member

Forked from #2726.

@smarterclayton @lavalamp

@bgrant0607 bgrant0607 added area/api Indicates an issue on api area. area/usability priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 3, 2015
@smarterclayton smarterclayton self-assigned this Mar 4, 2015
@smarterclayton
Copy link
Contributor

We fine with supporting both and deprecating /bindings in v1beta3?

@bgrant0607
Copy link
Member Author

Yes. I don't think this is gating for v1beta3, anyway. It's more in the "nice-to-have" category.

@lavalamp
Copy link
Member

lavalamp commented Mar 5, 2015

Yeah I think subresources will be cool but let's cut 1.0 before we go crazy with them.

@smarterclayton
Copy link
Contributor

Even if we don't introduce subresources, we need to get the common fixes in. I'll split those if we don't want to do bindings pre 1.0z

On Mar 4, 2015, at 11:09 PM, Daniel Smith notifications@github.com wrote:

Yeah I think subresources will be cool but let's cut 1.0 before we go crazy with them.


Reply to this email directly or view it on GitHub.

@smarterclayton
Copy link
Contributor

Actually, the subresources and client code are a small part of the pull. I'll disable those, but I think we should make the change to binding for v1 so we can use it for other types.

On Mar 4, 2015, at 11:09 PM, Daniel Smith notifications@github.com wrote:

Yeah I think subresources will be cool but let's cut 1.0 before we go crazy with them.


Reply to this email directly or view it on GitHub.

@lavalamp
Copy link
Member

lavalamp commented Mar 5, 2015

@smarterclayton if you're doing the work I have no objections :)

@bgrant0607
Copy link
Member Author

Sorry, I ran a doc fixit yesterday and am behind on PR reviews. Will try to get to this soon.

I would actually like to experiment with some subresources in v1beta3, so we can get experience with them. /binding should be pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/usability priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants