Fix storage tests for multizone test configuration. #50243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
|
/assign wojtek-t |
wojtek-t
reviewed
Aug 7, 2017
test/e2e/storage/volumes.go
Outdated
| @@ -429,6 +430,9 @@ var _ = SIGDescribe("Volumes", func() { | |||
| config = framework.VolumeTestConfig{ | |||
| Namespace: namespace.Name, | |||
| Prefix: "pd", | |||
| NodeSelector: map[string]string{ | |||
There was a problem hiding this comment.
Please add a comment why we are doing it.
wojtek-t
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, wojtek-t Associated issue requirement bypassed by: wojtek-t The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 50091, 50231, 50238, 50236, 50243) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Nov 29, 2017
#50238-#50243-upstream-release-1.7 Automatic merge from submit-queue. Automated cherry pick of #49708 #50238 #50243 upstream release 1.7 Automated cherrypick of #49708 #50238 #50243 upstream release 1.7 #49708 Add a support for GKE regional clusters in e2e tests. #50238 Modify e2e.go to arbitrarily pick one of zones we have nodes in for multizone tests. #50243 Fix storage tests for multizone test configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies "[sig-storage] Volumes PD should be mountable with (ext3|ext4)" tests to schedule pods in zone, where PD is created.
This is to make the test work in multizone environment.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: