Azure - Use cloud environment to instantiate storage client

[clement-buchart]

What this PR does / why we need it:
Since 1.7 and managed disk for azure, blob storage on Azure cloud other than the default public one is broken, because kubernetes expect blob ressources URI to end with .blob.core.windows.net (ignoring storageEndpointSuffix).
This include the chinese Cloud, for which storageEndpointSuffix is blob.core.chinacloudapi.cn for example.

See : https://github.com/Azure/azure-storage-go/blob/master/client.go#L194

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Support German cloud for azure disk mount feature

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @clement-buchart. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dims]

/ok-to-test

[k8s-github-robot]

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

[clement-buchart]

@dims Anything I am supposed to do to get this moving forward ?

Thanks :)

[dims]

/retest

[dims]

/assign @brendandburns

[dims]

/test all

[dims]

@clement-buchart things not marked 1.8 are mostly ignored right now. you will need reviews/approval from folks in the OWNERS file. some of them may not be using github notifications, so try slack or ask in the team meeting would be my suggestion

[brendandburns]

/retest
/lgtm
/approve no-issue

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, clement-buchart

Associated issue requirement bypassed by: brendandburns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/providers/azure/OWNERS [brendandburns]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions here..

[andyzhangx]

hi @clement-buchart we are fixing the same bug, and your PR get merged first. :) This PR should cherry-pick to v1.7, will you do that or shall I help you? Thanks.
I will close mine: #52878

[clement-buchart]

Here you go : #52962

But this this PR doesn't have a milestone, nor the cherrypick-candidate label, so I'm not sure how this is going to play out.

[ITler]

@andyzhangx May I kindly ask you to cherry pick this PR to next 1.7 release as this seems to be the remaining open point to get this merge into action? Thank you

[andyzhangx]

@ITler there is already a cherry pick PR #52962 for 1.7

[k8s-cherrypick-bot]

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.