Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --cloud-provider=auto-detect #50986

Closed
1 of 3 tasks
andrewsykim opened this issue Aug 20, 2017 · 25 comments · Fixed by #51312, #53573 or #56287
Closed
1 of 3 tasks

Remove --cloud-provider=auto-detect #50986

andrewsykim opened this issue Aug 20, 2017 · 25 comments · Fixed by #51312, #53573 or #56287
Assignees
@wlan0 @andrewsykim
Labels
area/cloudprovider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.10

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Aug 20, 2017 •
edited by luxas

/kind feature

What happened:
Continuing the discussion from #50730, we should deprecate (or remove since its alpha) the option to set --cloud-provider=auto-detect. See comment #50730 (comment) and #50730 (comment) for more details.

related issues: #48690
related kubernetes-dev thread: https://groups.google.com/forum/#!topic/kubernetes-dev/UAxwa2inbTA

EDIT:

Deprecation plan:

  • v1.8 - deprecate auto-detect cloud provider feature in kubelet
  • v1.9 - set no cloud provider as the default in kubelet but still allow opt in for auto-detect
  • v1.10 - completely remove the option to use auto-detect
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 20, 2017
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 20, 2017
@andrewsykim
Copy link
Member Author

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Aug 20, 2017
@andrewsykim
Copy link
Member Author

/area cloudprovider

@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 20, 2017
@andrewsykim
Copy link
Member Author

cc @wlan0 @jhorwit2

@wlan0
Copy link
Member

wlan0 commented Aug 21, 2017

/assign wlan0

@wlan0
Copy link
Member

wlan0 commented Aug 21, 2017

cc @thockin @luxas - Wanted to ask you if you had any thoughts for/against this issue?

@andrewsykim
Copy link
Member Author

/assign andrewsykim

As discussed in our meeting I'll be following up with sig-node to see if we can deprecate this as it's going against what we want for external cloud providers

@andrewsykim andrewsykim mentioned this issue Aug 25, 2017
Merged
@luxas
Copy link
Member

luxas commented Aug 25, 2017

FYI @kubernetes/sig-node-feature-requests @kubernetes/sig-cluster-lifecycle-feature-requests

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 25, 2017
k8s-github-robot pushed a commit that referenced this issue Aug 29, 2017
Merge pull request #51312 from andrewsykim/50986
7c70dec 
Automatic merge from submit-queue (batch tested with PRs 50932, 49610, 51312, 51415, 50705)

Deprecation warnings for auto detecting cloud providers

**What this PR does / why we need it**:
Adds deprecation warnings for auto detecting cloud providers. As part of the initiative for out-of-tree cloud providers, this feature is conflicting since we're shifting the dependency of kubernetes core into cAdvisor. In the future kubelets should be using `--cloud-provider=external` or no cloud provider at all. 

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50986

**Special notes for your reviewer**:
NOTE: I still have to coordinate with sig-node and kubernetes-dev to get approval for this deprecation, I'm only opening this PR since we're close to code freeze and it's something presentable.  

**Release note**:
```release-note
Deprecate auto detecting cloud providers in kubelet. Auto detecting cloud providers go against the initiative for out-of-tree cloud providers as we'll now depend on cAdvisor integrations with cloud providers instead of the core repo. In the near future, `--cloud-provider` for kubelet will either be an empty string or `external`. 
```
@andrewsykim
Copy link
Member Author

Would have been nice to keep this issue open to track progress in the next releases

@luxas luxas reopened this Sep 1, 2017
@luxas luxas added this to the v1.9 milestone Sep 1, 2017
@luxas
Copy link
Member

luxas commented Sep 1, 2017

Indeed, should be kept open.
Next task is now targeting v1.9

@andrewsykim
Copy link
Member Author

Thanks @luxas I edited the issue description to include the deprecation plan going forward. Open to changes on the deprecation plan if we think it's too aggressive.

@luxas
Copy link
Member

luxas commented Sep 1, 2017

Great, I think this is a good timeline. We need to make sure we communicate it very well though
@andrewsykim can you add this to the draft release notes in kubernetes/features please?

@wlan0 wlan0 mentioned this issue Sep 3, 2017
Closed
@andrewsykim
Copy link
Member Author

Looks like you beat me to it 😛, gave it a review.

@luxas
Copy link
Member

luxas commented Sep 4, 2017

hehe, yes, added it at the same time as everything else ;)

@luxas luxas added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 6, 2017
@luxas luxas added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 6, 2017
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2017
@luxas luxas added status/approved-for-milestone and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 6, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Issue Current

@andrewsykim @wlan0

Issue Labels
  • sig/cluster-lifecycle sig/node: Issue will be escalated to these SIGs if needed.
  • priority/important-longterm: Escalate to the issue owners; move out of the milestone after 1 attempt.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@dims dims mentioned this issue Oct 9, 2017
Merged
@dims
Copy link
Member

dims commented Oct 9, 2017

@andrewsykim i took the liberty to move this along (filed 53573). Hope that's ok.

@andrewsykim
Copy link
Member Author

Thanks @dims, appreciate it. I think there were some discussions in the mailing list thread about v1.9 being too soon. I think it largely depends on how many users actually take advantage of the auto-detect feature. It's not many from what I've seen but we should follow up and be sure.

@luxas
Copy link
Member

luxas commented Oct 9, 2017

@andrewsykim Any recent discussion about that? I haven't seen any activity recently but I might just be subject to email overflow. I hope we can get this into v1.9
cc @thockin

@dchen1107
Copy link
Member

I didn't follow any discussion related to this topic, but thought this is right move to decouple cloud_provider components from the core system. If I remembered correctly, only cloud_providers for GCE, AWS and Azura depend on the feature, which can be easily override.

Any concerns for v1.9?

@dims
Copy link
Member

dims commented Oct 9, 2017

@dchen1107 yep, GCE/AWS/Azure - https://github.com/google/cadvisor/blob/a9b1ab1dd8d811d419487a631c3361df582346d2/utils/cloudinfo/cloudinfo.go#L58

@luxas
Copy link
Member

luxas commented Oct 9, 2017

@dchen1107 Please look at #53573 and give your LGTM

@dchen1107
Copy link
Member

Done. Just better document in 1.9 release notes. LGTM

@luxas
Copy link
Member

luxas commented Oct 9, 2017

Thank you!

k8s-github-robot pushed a commit that referenced this issue Oct 9, 2017
Merge pull request #53573 from dims/remove-auto-detect-as-default-for…
8659623 
…-kubelet

Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Do not set auto-detect cloud provider as the default in kubelet

**What this PR does / why we need it**:

This is part of the move to external cloud providers. Please see
plan detail in issue 50986. This PR covers step 2:
 v1.9 - set no cloud provider as the default in kubelet but still allow
 opt in for auto-detect

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
Fixes: #50986

**Special notes for your reviewer**:

**Release note**:

```release-note
kubelet's `--cloud-provider` flag no longer defaults to "auto-detect".  If you want cloud-provider support in kubelet, you must set a specific cloud-provider explicitly.
```
@luxas
Copy link
Member

luxas commented Oct 9, 2017

Reopening for the removal of the option in v1.10

@luxas luxas reopened this Oct 9, 2017
@dims
Copy link
Member

dims commented Nov 15, 2017

@enisoc please move this to 1.10 milestone

@enisoc enisoc modified the milestones: v1.9, v1.10 Nov 15, 2017
@stewart-yu stewart-yu mentioned this issue Nov 23, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Dec 16, 2017
Merge pull request #56287 from stewart-yu/removeDeprecatedCode
d936754 
Automatic merge from submit-queue (batch tested with PRs 54902, 56831, 56702, 56287, 56878). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove the kubelet's `--cloud-provider=auto-detect` feature

**What this PR does / why we need it**:
 Set no cloud provider as the default in kubelet, remove deprecated explain and variable.
This PR covers step 3:
 `v1.10 - completely remove the option to use auto-detect`

For more details [#50986

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#50986

**Special notes for your reviewer**:

**Release note**:

```release-note
[action required] Remove the kubelet's `--cloud-provider=auto-detect` feature
```
@lukaszgryglicki lukaszgryglicki mentioned this issue Mar 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlan0 wlan0

@andrewsykim andrewsykim

Labels
area/cloudprovider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.10
8 participants
@dims @wlan0 @luxas @enisoc @dchen1107 @andrewsykim @k8s-github-robot @k8s-ci-robot