Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatefulSet controller sets immutable fields of v1.PodSpec #51043

Closed
kow3ns opened this issue Aug 21, 2017 · 0 comments · Fixed by #51044
Closed

StatefulSet controller sets immutable fields of v1.PodSpec #51043

kow3ns opened this issue Aug 21, 2017 · 0 comments · Fixed by #51044
Assignees
@kow3ns
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@kow3ns
Copy link
Member

kow3ns commented Aug 21, 2017

Part of the cause of #48327 is that the StatefulSet controller attempts to set the v1.PodSpec .Hostname and v1.PodSpec.Subdomain fields. Though the alpha annotations corresponding to these fields were mutable, and the though the endpoints controller could create new endpoints based on the mutation of these fields, kubelet does not seem sensitive to their mutation, and mutation of the fields is not supported in the v1.PodSpec API object.

BUG REPORT:
/kind bug
@kow3ns kow3ns self-assigned this Aug 21, 2017
@kow3ns kow3ns added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Aug 21, 2017
@kow3ns kow3ns mentioned this issue Aug 21, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 22, 2017
Merge pull request #51044 from kow3ns/sts-immutable-network-id
336e38b 
Automatic merge from submit-queue (batch tested with PRs 51102, 50712, 51037, 51044, 51059)

fix #51043

**What this PR does / why we need it**: The StatefulSet controller no longer attempts to mutate "hostname" or "subdomain" fields of the "pod.spec" to enforce the network identity of Pods in a StatefeulSet. Since these fields are set upon creation and immutable thereafter setting the annotations is no longer necessary. 
fixes: #51043
@kow3ns kow3ns mentioned this issue Aug 22, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 23, 2017
Merge pull request #51149 from kow3ns/cherry-pick-fix-51043
e2b776a 
Automatic merge from submit-queue

Manual cherrypick of #51043

StatefulSet controller no longer attempts to mutate v1.PodSpec.Hostname or v1.PodSpec.Subdomain
fixes: #51043 
Partial fix for #48327 

Manual cherrypick of #51044

```release-note
StatefulSet: Fix "forbidden pod updates" error on Pods created prior to upgrading to 1.7. (#48327)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kow3ns kow3ns

Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StatefulSet: Don't try to update immutable hostname/subdomain fields. kow3ns/kubernetes
1 participant
@kow3ns