Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement InstanceExistsByProviderID() for all the cloud providers #51406

Closed
FengyunPan opened this issue Aug 26, 2017 · 4 comments
Closed

Implement InstanceExistsByProviderID() for all the cloud providers #51406

FengyunPan opened this issue Aug 26, 2017 · 4 comments
Assignees
@FengyunPan
Labels
area/cloudprovider kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@FengyunPan
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

What you expected to happen:
Related to #50985
Since #51087 merged, we should implement this method for all the cloud providers.

Anything else we need to know?:
Many cloud providers(like aws, gce etc...) implement ExternalID(), they also implement InstanceExistsByProviderID(), I can fill it soon.
/cc @wlan0 @thockin @luxas @jhorwit2

/area cloudprovider
/sig cluster-lifecycle
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/cloudprovider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 26, 2017
@jhorwit2
Copy link
Contributor

Thanks @FengyunPan you beat me to it :)

@FengyunPan
Copy link
Author

FengyunPan commented Aug 26, 2017 •
edited

@jhorwit2 Do you mean you want to implement them?

@jhorwit2
Copy link
Contributor

No, I was just saying thanks for creating the ticket to track it! I was about to do the same after I saw the PR merged.

@FengyunPan
Copy link
Author

Yeah, I will implement them soon.

FengyunPan pushed a commit to FengyunPan/kubernetes that referenced this issue Aug 26, 2017
Implement InstanceExistsByProviderID() for cloud providers
2858447 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().
@FengyunPan FengyunPan mentioned this issue Aug 26, 2017
Merged
@andrewsykim andrewsykim mentioned this issue Aug 27, 2017
Closed
FengyunPan pushed a commit to FengyunPan/kubernetes that referenced this issue Aug 30, 2017
Implement InstanceExistsByProviderID() for cloud providers
8dc384b 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().
@wlan0 wlan0 mentioned this issue Sep 3, 2017
Closed
FengyunPan pushed a commit to FengyunPan/kubernetes that referenced this issue Sep 5, 2017
Implement InstanceExistsByProviderID() for cloud providers
691d0fc 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID(). InstanceExistsByProviderID() just
check whether instance exists.
@karataliu karataliu mentioned this issue Sep 15, 2017
Closed
25 tasks
FengyunPan pushed a commit to FengyunPan/kubernetes that referenced this issue Oct 9, 2017
Implement InstanceExistsByProviderID() for cloud providers
db3721b 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().
FengyunPan pushed a commit to FengyunPan/kubernetes that referenced this issue Oct 20, 2017
@FengyunPan2
Implement InstanceExistsByProviderID() for cloud providers
462087f 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().
k8s-github-robot pushed a commit that referenced this issue Oct 27, 2017
Merge pull request #51409 from FengyunPan/implement-InstanceExistsByP…
55e49ed 
…roviderID

Automatic merge from submit-queue (batch tested with PRs 51409, 54616). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Implement InstanceExistsByProviderID() for cloud providers

Fix #51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().

/assign wlan0
/assign @luxas

**Release note**:
```release-note
NONE
```
dims pushed a commit to dims/kubernetes that referenced this issue Feb 8, 2018
@FengyunPan2
Implement InstanceExistsByProviderID() for cloud providers
93acbe8 
Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().
dims pushed a commit to dims/kubernetes that referenced this issue Feb 8, 2018
Merge pull request kubernetes#51409 from FengyunPan/implement-Instanc…
b205af9 
…eExistsByProviderID

Automatic merge from submit-queue (batch tested with PRs 51409, 54616). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Implement InstanceExistsByProviderID() for cloud providers

Fix kubernetes#51406
If cloud providers(like aws, gce etc...) implement ExternalID()
and support getting instance by ProviderID , they also implement
InstanceExistsByProviderID().

/assign wlan0
/assign @luxas

**Release note**:
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FengyunPan FengyunPan

Labels
area/cloudprovider kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhorwit2 @FengyunPan @k8s-ci-robot