Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod MountPropagation needs clearing when disabled #51738

Closed
jsafrane opened this issue Aug 31, 2017 · 4 comments · Fixed by #51893
Closed

Pod MountPropagation needs clearing when disabled #51738

jsafrane opened this issue Aug 31, 2017 · 4 comments · Fixed by #51893
Assignees
@jsafrane
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
v1.8

Comments

@jsafrane
Copy link
Member

jsafrane commented Aug 31, 2017 •
edited

api_changes.md says "Before persisting the object to storage, clear disabled alpha fields". There is #50924 that actually implements it but there are some discussions about it.

This issues is a reminder that pod.containers[i].volumeMounts[j].mountPropagation introduced by #46444 needs to be cleared too when the discussion in #50924 settles down.

/assign @jsafrane
@jsafrane jsafrane added this to the v1.8 milestone Aug 31, 2017
@k8s-github-robot
Copy link

@jsafrane
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. milestone-labels-incomplete labels Aug 31, 2017
@cblecker
Copy link
Member

cblecker commented Sep 4, 2017

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 4, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 4, 2017
@jsafrane
Copy link
Member Author

jsafrane commented Sep 4, 2017

kind/cleanup
priority/important-soon

@jsafrane jsafrane mentioned this issue Sep 4, 2017
Merged
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 4, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Labels Complete

@jsafrane

Issue label settings:

  • sig/api-machinery: Issue will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Additional instructions available here

k8s-github-robot pushed a commit that referenced this issue Sep 5, 2017
Merge pull request #51893 from jsafrane/clear-alpha-mount-propagation
58fe20f 
Automatic merge from submit-queue (batch tested with PRs 51180, 51893)

Clear alpha MountPropagation fields.

This is leftover from #50924, mount propagation introduced a new field that needs to be cleared.

**Which issue this PR fixes**
fixes #51738

**Release note**:

```release-note
NONE
```


@k8s-mirror-api-machinery-pr-reviews 
/assign @liggitt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsafrane jsafrane

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Clear alpha MountPropagation fields. jsafrane/kubernetes
5 participants
@liggitt @cblecker @jsafrane @k8s-github-robot @k8s-ci-robot