Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the relation of ExecInContainer and Exec #52513

Merged
merged 1 commit into from Nov 1, 2017
Merged

improve the relation of ExecInContainer and Exec #52513

merged 1 commit into from Nov 1, 2017

Conversation

yanxuean
Copy link
Contributor

@yanxuean yanxuean commented Sep 15, 2017 •
edited

keep the relation between ExecInContainer and Exec be consistence with PortForward in streaming server

fix #54903
Signed-off-by: yanxuean yan.xuean@zte.com.cn

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@yanxuean
improve the relation of ExecInContainer and Exec
3150d3e 
keep the relation between ExecInContainer and Exec be consistence with PortForward in streaming server

Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yanxuean. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 15, 2017
@xiangpengzhao
Copy link
Contributor

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2017
@yanxuean
Copy link
Contributor Author

/retest

@yanxuean
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@yanxuean
Copy link
Contributor Author

yanxuean commented Oct 13, 2017 •
edited

/assign @vishh
PTAL

@yanxuean
Copy link
Contributor Author

/sig node
/assign @Random-Liu

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 13, 2017
@yanxuean
Copy link
Contributor Author

@vishh PTAL , Thanks

@yanxuean
Copy link
Contributor Author

ping for approve @Random-Liu

@mtaufen
Copy link
Contributor

mtaufen commented Oct 24, 2017

/lgtm
Looks like a no-op change, and good to be consistent.
@Random-Liu

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2017
@yanxuean
Copy link
Contributor Author

@yujuhong PTAL

@xiangpengzhao
Copy link
Contributor

/test pull-kubernetes-e2e-gce

@Random-Liu
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtaufen, Random-Liu, yanxuean

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yanxuean
Copy link
Contributor Author

/retest

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2017
@xiangpengzhao
Copy link
Contributor

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 705de0a into kubernetes:master Nov 1, 2017
@yanxuean yanxuean deleted the streamExec branch November 1, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmorie pmorie

@mtaufen mtaufen

@Random-Liu Random-Liu

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve the relation of ExecInContainer and Exec
8 participants
@yanxuean @k8s-ci-robot @xiangpengzhao @mtaufen @Random-Liu @k8s-github-robot @pmorie @vishh