-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the relation of ExecInContainer and Exec #52513
Conversation
keep the relation between ExecInContainer and Exec be consistence with PortForward in streaming server Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
Hi @yanxuean. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/release-note-none |
/retest |
/test pull-kubernetes-e2e-gce-bazel |
/assign @vishh |
/sig node |
@vishh PTAL , Thanks |
ping for approve @Random-Liu |
/lgtm |
@yujuhong PTAL |
/test pull-kubernetes-e2e-gce |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtaufen, Random-Liu, yanxuean No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
/test pull-kubernetes-unit |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
keep the relation between ExecInContainer and Exec be consistence with PortForward in streaming server
fix #54903
Signed-off-by: yanxuean yan.xuean@zte.com.cn
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: