Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move other release notes out of CHANGELOG.md #52719

Merged

Conversation

xiangpengzhao
Copy link
Contributor

What this PR does / why we need it:
Move 1.4, 1.5, 1.6 release notes out of CHANGELOG.md.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
ref: #48985 #52174 #52518

Special notes for your reviewer:
Not move 1.7 release notes yet. I don't think we want to move it out of CHANGELOG.md until 1.8 is released.
/cc @jdumars @dchen1107

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2017
@jdumars
Copy link
Member

jdumars commented Sep 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2017
@jdumars jdumars added this to the v1.8 milestone Sep 19, 2017
@xiangpengzhao
Copy link
Contributor Author

/retest

@brendandburns
Copy link
Contributor

/approve no-issue
/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, jdumars, xiangpengzhao

Associated issue: 48985

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 5c7dab4 into kubernetes:master Sep 20, 2017
@xiangpengzhao xiangpengzhao deleted the move-other-release-notes branch September 20, 2017 22:15
k8s-github-robot pushed a commit that referenced this pull request Sep 29, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Move 1.6.11 changelog to CHANGELOG-1.6.md

**What this PR does / why we need it**:
We have moved 1.6.* changelog to CHANGELOG-1.6.md. So the latest 1.6.11 changelog should be in CHANGELOG-1.6.md.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
ref: #48985 #52719

**Special notes for your reviewer**:
/cc @enisoc 
We may want to move 1.7.* changelog to a separate file CHANGELOG-1.7.md when 1.8.0 is live.

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants