Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl proxy doesn't redirect to kubernetes dashboard correctly #52813

Closed
rohitagarwal003 opened this issue Sep 20, 2017 · 3 comments · Fixed by #52933
Closed

kubectl proxy doesn't redirect to kubernetes dashboard correctly #52813

rohitagarwal003 opened this issue Sep 20, 2017 · 3 comments · Fixed by #52933
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@rohitagarwal003
Copy link
Member

/kind bug

I created a cluster (tried both on GKE and GCE) running Kubernetes 1.7.6

I ran kubectl proxy

Then I tried to access http://127.0.0.1/ui
It redirected to http://127.0.0.1:8001/api/v1/namespaces/kube-system/services/kubernetes-dashboard/proxy which showed a blank page.

It should have either redirected to:
http://127.0.0.1:8001/api/v1/namespaces/kube-system/services/kubernetes-dashboard/proxy/ (note the trailing /)
or
http://127.0.0.1:8001/api/v1/proxy/namespaces/kube-system/services/kubernetes-dashboard/ (note the placement of proxy).
Both these URLs work.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2017
@k8s-github-robot
Copy link

@mindprince
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 20, 2017
@rohitagarwal003
Copy link
Member Author

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Sep 20, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 20, 2017
@TomskDiver
Copy link

duplicate: #52729

@roycaihw roycaihw mentioned this issue Sep 22, 2017
Closed
@liggitt liggitt mentioned this issue Sep 23, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 23, 2017
Merge pull request #52933 from liggitt/proxy-subpath-slash
e0f7533 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Preserve leading and trailing slashes on proxy subpaths

subresource parsing was not populating path parameters correctly (leading and trailing slashes were being stripped)

this caused bad locations to be sent to the proxy, causing #52022. the first attempt to fix that (#52065) unconditionally prefixed '/', which broke the redirect case (#52813 #52729)

fixes #52813, fixes #52729

needs to be picked to 1.7 and 1.8

```release-note
Restores redirect behavior for proxy subresources
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
4 participants
@rohitagarwal003 @TomskDiver @k8s-github-robot @k8s-ci-robot