Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GC ratelimiter metrics #52867

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Remove GC ratelimiter metrics #52867

merged 1 commit into from
Sep 22, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 21, 2017 •
edited

Fixes #52801

The metrics were causing panics because the names weren't formatted correctly, there were concerns around the number of metrics series that resulted from registration per group/version, and the saturation metric being reported was of questionable use

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 21, 2017
@smarterclayton
Copy link
Contributor

I would prefer to disable GC metrics altogether rather than continue to do this as "metric per group version" vs "label and series per group version" which is the correct way. We threw some of these metrics in and we didn't actually follow the appropriate patterns.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2017
@liggitt liggitt changed the title Make gc metrics valid names, log metrics errors Remove GC ratelimiter metrics Sep 21, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 21, 2017

updated to remove GC ratelimiter metric registration

@cheftako
Copy link
Member

cc @cheftako

@liggitt
Copy link
Member Author

liggitt commented Sep 21, 2017

@deads @caesarxuchao @ironcladlou for GC
@smarterclayton for prometheus opinions

@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Sep 21, 2017
@liggitt liggitt added this to the v1.8 milestone Sep 21, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2017
cheftako
cheftako approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We do need to start protecting ourselves from the prometheseus.MustRegister() call but I have filed a separate issue for that.

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, liggitt, smarterclayton

Associated issue: 52801

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 22, 2017 •
edited

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel a0f8a36 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit cec8acf into kubernetes:master Sep 22, 2017
@liggitt liggitt deleted the metric-name branch September 25, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako approved these changes

Assignees

@cheftako cheftako

@smarterclayton smarterclayton

@caesarxuchao caesarxuchao

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liggitt @smarterclayton @cheftako @k8s-github-robot @k8s-ci-robot @lavalamp @caesarxuchao @thockin @deads2k