Automated cherry pick of #48326 #53172
Conversation
k8s-ci-robot
added
size/XS
|
Hi @andyzhangx. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
added
do-not-merge/cherry-pick-not-approved
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/release-note |
k8s-ci-robot
added
release-note
|
@andyzhangx please refer old PR #48326 in the title, e.g. |
andyzhangx
changed the title
|
/retest |
| name := volume.GenerateVolumeName(a.options.ClusterName, a.options.PVName, 75) | ||
| // File share name has a length limit of 63, and it cannot contain two consecutive '-'s. | ||
| name := volume.GenerateVolumeName(a.options.ClusterName, a.options.PVName, 63) | ||
| name = strings.Replace(name, "--", "-", -1) | ||
| capacity := a.options.PVC.Spec.Resources.Requests[v1.ResourceName(v1.ResourceStorage)] |
There was a problem hiding this comment.
Some test/docs would be nice about why we are doing what we are doing and also making sure it doesn't regress.
There was a problem hiding this comment.
yes, I will add azure file test case in master branch first, since this is only a cherry pick, shall we merge this PR first?
There was a problem hiding this comment.
@gnufied agreed with andy, this is a cherry-pick aimed to fix a critical bug.
There was a problem hiding this comment.
The original PR was opened without cherry-pick title I think, so I didn't think it was a cherry-pick.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-e2e-gce-bazel |
|
/approve |
|
@andyzhangx can you link the github issue this PR fixes? |
|
/test pull-kubernetes-e2e-gce-bazel |
2 similar comments
|
/test pull-kubernetes-e2e-gce-bazel |
|
/test pull-kubernetes-e2e-gce-bazel |
|
@gnufied I have updated the |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, gnufied Associated issue requirement bypassed by: gnufied The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
@brendanburns could you approve, thx |
|
/assign @wojtek-t |
|
@wojtek-t could you help to approve the cherry-pick? thanks. |
wojtek-t
added
cherry-pick-approved
|
Approved. |
|
@wojtek-t thanks |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
andyzhangx
deleted the
automated-cherry-pick-of-#48326-upstream-release-1.7-1506563999
branch
What this PR does / why we need it:
Azure file share name has a length limit of 63, but currently the code is using data volume's limit 75.
Which issue this PR fixes
cherry-pick fix of #48326
With current implementation, when the cluster name is long, the resulting file share name could have a length of 75.
Also function GenerateVolumeName would produce double '-' when clusterName containing '-' is to be truncated.
In both cases, service would reject the creating file share request.
Special notes for your reviewer:
Please refer to:
https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata#share-names
Share names must be from 3 through 63 characters long.
The name cannot contain two consecutive hyphens.
Release note: