Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciliation adds duplicated subjects on server start #53296

Closed
enj opened this issue Sep 30, 2017 · 3 comments
Closed

Reconciliation adds duplicated subjects on server start #53296

enj opened this issue Sep 30, 2017 · 3 comments
Assignees
@enj
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth.

Comments

@enj
Copy link
Member

enj commented Sep 30, 2017

/kind bug

What happened:

Bootstrapped RBAC role bindings incorrectly add duplicate subjects on server start.

What you expected to happen:

Reconciliation should not add subjects that already exist.

How to reproduce it (as minimally and precisely as possible):

Restart an API master multiple time. See that bootstrap role bindings have duplicated subjects.

Environment:

master: d2bbeb6

xref openshift/origin#16611
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 30, 2017
@enj enj mentioned this issue Sep 30, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 30, 2017
@k8s-github-robot
Copy link

@enj
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@enj
Copy link
Member Author

enj commented Sep 30, 2017

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Sep 30, 2017
@enj
Copy link
Member Author

enj commented Sep 30, 2017

/assign @enj

@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 30, 2017
k8s-github-robot pushed a commit that referenced this issue Sep 30, 2017
Merge pull request #53239 from enj/enj/i/role_binding_api_group/16611
72d9774 
Automatic merge from submit-queue (batch tested with PRs 51034, 53239). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Correct APIGroup for RoleBindingBuilder Subjects

This change corrects `RoleBindingBuilder` to use the RBAC API group with users and groups as subjects (service accounts use the empty string since they are in the legacy core group).  This is based on the defaulting in `pkg/apis/rbac/v1/defaults.go#SetDefaults_Subject`.  This is required because the bootstrap RBAC data is built with these helpers and does not go through defaulting, whereas the data retrieved from the server has already gone through defaulting.  This can lead to the reconciliation code incorrectly adding duplicate subjects because it believes that they are missing (since the API groups do not match).

Signed-off-by: Monis Khan <mkhan@redhat.com>

```release-note
Fixes an issue with RBAC reconciliation that could cause duplicated subjects in some bootstrapped rolebindings on each restart of the API server.
```

/assign @liggitt
/sig auth

Fixes #53296
Fixes openshift/origin/issues/16611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enj enj

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enj @k8s-github-robot @k8s-ci-robot