Mark BetaStorageClassAnnotation as deprecated

[xiangpengzhao]

What this PR does / why we need it:
Mark BetaStorageClassAnnotation as deprecated.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
ref: #51440
#51440 (comment)

Special notes for your reviewer:
/cc @wongma7 @msau42

Release note:

action required: The `volume.beta.kubernetes.io/storage-class` annotation is deprecated. It will be removed in a future release. For the StorageClass API object, use v1, and in place of the annotation use `v1.PersistentVolumeClaim.Spec.StorageClassName` and `v1.PersistentVolume.Spec.StorageClassName` instead.

[xiangpengzhao]

/cc @jsafrane

[jsafrane]

• release note should mention also PersistentVolume, it had beta annotation too
• IMO, we should deprecate also storage.k8s.io/v1beta1 API too

[xiangpengzhao]

@jsafrane release note updated. PTAL. Thanks!
BTW, I don't find where to mark storage.k8s.io/v1beta1 as deprecated in the code... Is it OK to just mark it in the release note?

[xiangpengzhao]

/cc @kubernetes/sig-storage-pr-reviews

[jsafrane]

/assign

[jsafrane]

/lgtm

[xiangpengzhao]

Thanks @jsafrane !

kindly ping api-approvers @liggitt @lavalamp

[xiangpengzhao]

/assign @erictune

[jsafrane]

/lgtm

[jsafrane]

/assign @thockin
for approval

[thockin]

/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, thockin, xiangpengzhao

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/apis/core/OWNERS [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 53580, 55568). If you want to cherry-pick this change to another branch, please follow the instructions here.

[msau42]

@jsafrane @saad-ali and I discussed. We're just going to deprecate the beta storageclass annotation and not the beta storageclass API object.

[xiangpengzhao]

@msau42 thanks for notifying! I see the release notes doc has been updated, so I also update the release note block in this PR to make it consistence with that.

[george-angel]

What is the upgrade path for this?

We cannot remove the annotation, as its immutable: * spec: Forbidden: field is immutable after creation nor can we add the StorateClassName to the spec: The PersistentVolumeClaim "********" is invalid: spec: Forbidden: field is immutable after creation.

So I don't see how we can match our version of the manifest to the one thats currently running in the cluster.

[jsafrane]

@george-angel, good catch, I created #58147 so we don't forget to fix this.