Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gate for allocatable disk eviction #53684

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Add feature gate for allocatable disk eviction #53684

merged 1 commit into from
Oct 12, 2017

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 11, 2017 •
edited

Issue: #52336
This PR adds the local storage feature gate to local storage allocatable eviction.

cc @kubernetes/sig-node-bugs
/assign @jingxu97 @dchen1107

we should target this for 1.7 if possible.

fix a bug where disk pressure could trigger prematurely when using overlay2

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2017
@dchen1107
Copy link
Member

Please fix the compilation issue:

W1011 00:15:37.377] 2017/10/11 00:15:37 error running compiler: exit status 1
I1011 00:15:37.478] pkg/kubelet/eviction/helpers.go:793: undefined: utilfeature in utilfeature.DefaultFeatureGate
I1011 00:15:37.480] pkg/kubelet/eviction/helpers.go:793: undefined: features in features.LocalStorageCapacityIsolation

@dchen1107
Copy link
Member

/approve

@dchen1107 dchen1107 added this to the v1.8 milestone Oct 11, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2017
@dchen1107
Copy link
Member

cc/ @kubernetes/sig-release-members for both 1.7 and 1.8 patch release.

@dashpole dashpole force-pushed the feature_gate_allocatable_eviction branch from 2e5f56e to 705ad9e Compare October 11, 2017 00:52
@dashpole dashpole force-pushed the feature_gate_allocatable_eviction branch from 705ad9e to 8659676 Compare October 11, 2017 16:58
@dashpole
Copy link
Contributor Author

I verified with a test run with LocalStorageCapacityIsolation=False:
eviction manager: no observation found for eviction signal allocatableNodeFs.available

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2017
@dchen1107
Copy link
Member

Looks good to me. But @jingxu97 suggested to have feature gate at https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/container_manager_linux.go#L597, I don't have a strong opinion on where to feature gate though.

@dashpole
Copy link
Contributor Author

re #53684 (comment),
I thought about doing it there as well, but felt this was the best way to turn off this specific behavior. I also wanted as small of a cherrypick as possible.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

Associated issue: 52336

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0515895 into kubernetes:master Oct 12, 2017
@dashpole dashpole mentioned this pull request Oct 12, 2017
Merged
@dashpole dashpole deleted the feature_gate_allocatable_eviction branch October 12, 2017 23:21
@dashpole dashpole mentioned this pull request Oct 12, 2017
Merged
@wojtek-t wojtek-t modified the milestones: v1.8, v1.7 Oct 13, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 13, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 24, 2017
Merge pull request #53843 from dashpole/automated-cherry-pick-of-#536…
1583890 
…84-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #53684 upstream release 1.7

cherrypick of #53684 to the 1.7 branch

/assign @jepbtz

```release-note
mitigate a bug where disk pressure could trigger prematurely when using overlay2
```
cc @jingxu97 @dchen1107
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Oct 31, 2017
Merge pull request #53840 from dashpole/automated-cherry-pick-of-#536…
f88b2b1 
…84-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53684 upstream release 1.8

cherrypick of #53684 to the 1.8 branch

```release-note
Fix a bug where disk pressure could trigger prematurely when using overlay2
```
cc @jingxu97 @dchen1107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dashpole @dchen1107 @k8s-github-robot @k8s-cherrypick-bot @wojtek-t @jingxu97 @k8s-ci-robot