-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gate for allocatable disk eviction #53684
Add feature gate for allocatable disk eviction #53684
Conversation
Please fix the compilation issue: W1011 00:15:37.377] 2017/10/11 00:15:37 error running compiler: exit status 1 |
/approve |
cc/ @kubernetes/sig-release-members for both 1.7 and 1.8 patch release. |
2e5f56e
to
705ad9e
Compare
705ad9e
to
8659676
Compare
I verified with a test run with LocalStorageCapacityIsolation=False: |
Looks good to me. But @jingxu97 suggested to have feature gate at https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/container_manager_linux.go#L597, I don't have a strong opinion on where to feature gate though. |
re #53684 (comment), |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dchen1107 Associated issue: 52336 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
…84-upstream-release-1.7 Automatic merge from submit-queue. Automated cherry pick of #53684 upstream release 1.7 cherrypick of #53684 to the 1.7 branch /assign @jepbtz ```release-note mitigate a bug where disk pressure could trigger prematurely when using overlay2 ``` cc @jingxu97 @dchen1107
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…84-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #53684 upstream release 1.8 cherrypick of #53684 to the 1.8 branch ```release-note Fix a bug where disk pressure could trigger prematurely when using overlay2 ``` cc @jingxu97 @dchen1107
Issue: #52336
This PR adds the local storage feature gate to local storage allocatable eviction.
cc @kubernetes/sig-node-bugs
/assign @jingxu97 @dchen1107
we should target this for 1.7 if possible.