Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #53684 upstream release 1.7 #53843

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Automated cherry pick of #53684 upstream release 1.7 #53843

merged 1 commit into from
Oct 24, 2017

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 12, 2017 •
edited

cherrypick of #53684 to the 1.7 branch

/assign @jepbtz

mitigate a bug where disk pressure could trigger prematurely when using overlay2

cc @jingxu97 @dchen1107

@k8s-ci-robot
Copy link
Contributor

@dashpole: GitHub didn't allow me to assign the following users: jepbtz.

Note that only kubernetes members can be assigned.

In response to this:

cherrypick of #53684 to the 1.7 branch

/assign @jepbtz

fix a bug where disk pressure could trigger prematurely when using overlay2

cc @jingxu97 @dchen1107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 12, 2017
@dashpole
Copy link
Contributor Author

/assign @wojtek-t
/unassign @dchen1107 @yifan-gu

@k8s-ci-robot k8s-ci-robot assigned wojtek-t and unassigned yifan-gu and dchen1107 Oct 12, 2017
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 13, 2017
@wojtek-t
Copy link
Member

@dchen1107 @jingxu97 - can you please LGTM it?

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 18, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

Associated issue: 53684

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2017
@wojtek-t wojtek-t added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2017
@wojtek-t
Copy link
Member

I'm temporarily adding do-not-merge label, because we are building 1.7.9 now. Will remove it once this is finished.

@wojtek-t wojtek-t removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2017
@wojtek-t
Copy link
Member

Sorry for delay - this is ready to be merged now.

@wojtek-t
Copy link
Member

@k8s-bot you're stupid

@wojtek-t
Copy link
Member

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@wojtek-t wojtek-t closed this Oct 24, 2017
@wojtek-t wojtek-t reopened this Oct 24, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 1583890 into kubernetes:release-1.7 Oct 24, 2017
@dashpole dashpole deleted the automated-cherry-pick-of-#53684-upstream-release-1.7 branch November 30, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

@wojtek-t wojtek-t

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dashpole @k8s-ci-robot @wojtek-t @dchen1107 @k8s-github-robot @yifan-gu @jingxu97