Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validate ipvs sheduler options #53975

Closed
m1093782566 opened this issue Oct 16, 2017 · 0 comments · Fixed by #53973
Closed

Should validate ipvs sheduler options #53975

m1093782566 opened this issue Oct 16, 2017 · 0 comments · Fixed by #53973
Labels
area/kube-proxy kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@m1093782566
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

IPVS sheduler options has no validation. For example, if we pass an unsupported --ipvs-scheduler option(e.g. foo) for kube-proxy, it will cause unexpected error.

What you expected to happen:

Should validate ipvs sheduler options.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration**:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig network

/area kube-proxy
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. area/kube-proxy labels Oct 16, 2017
@m1093782566 m1093782566 mentioned this issue Oct 16, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Oct 30, 2017
Merge pull request #53973 from m1093782566/validate-sheduler
878814b 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

validate ipvs scheduler

**What this PR does / why we need it**:

validate ipvs scheduler options

**Which issue this PR fixes**: 

closes #53975

**Special notes for your reviewer**:

It depends on work of #53780.

**Release note**:

```release-note
NONE
```

/sig network

/area kube-proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kube-proxy kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate ipvs scheduler m1093782566/kubernetes
2 participants
@m1093782566 @k8s-ci-robot