Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet cannot show Docker-CE version correctly #54039

Closed
dixudx opened this issue Oct 17, 2017 · 6 comments · Fixed by #54040
Closed

kubelet cannot show Docker-CE version correctly #54039

dixudx opened this issue Oct 17, 2017 · 6 comments · Fixed by #54040
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@dixudx
Copy link
Member

dixudx commented Oct 17, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

What happened:

  1. Install Docker-CE
$ docker version
Client:
 Version:      17.09.0-ce
 API version:  1.32
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:42:18 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.09.0-ce
 API version:  1.32 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:40:56 2017
 OS/Arch:      linux/amd64
 Experimental: false
  1. Bootstrap K8s cluster normally
  2. when getting nodes,
$ kubectl get node -o wide
NAME        STATUS    ROLES     AGE       VERSION   EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
server-02   Ready     master    1d        v1.8.1    <none>        Ubuntu 16.04.2 LTS   4.4.0-83-generic   docker://Unknown

What you expected to happen:
Should show a version intead of docker://Unknown, which is confusing.

How to reproduce it (as minimally and precisely as possible):
As above

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.1", GitCommit:"f38e43b221d08850172a9a4ea785a86a3ffa3b3a", GitTreeState:"clean", BuildDate:"2017-10-11T23:27:35Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.1", GitCommit:"f38e43b221d08850172a9a4ea785a86a3ffa3b3a", GitTreeState:"clean", BuildDate:"2017-10-11T23:16:41Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@dixudx dixudx mentioned this issue Oct 17, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 17, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 17, 2017

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 17, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 17, 2017
k8s-github-robot pushed a commit that referenced this issue Oct 17, 2017
Merge pull request #54040 from dixudx/fix_kubelet_runtime_version_par…
86f7e27 
…sing

Automatic merge from submit-queue (batch tested with PRs 54040, 52503). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

falls back to parse Docker runtime version as generic if not semver

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54039

**Special notes for your reviewer**:
/assign @tallclair @vishh 

**Release note**:

```release-note
falls back to parse Docker runtime version as generic if not semver
```
@xyalan
Copy link

xyalan commented Dec 1, 2017

I have same problem in v1.8.3+coreos.0.

@dixudx
Copy link
Member Author

dixudx commented Dec 1, 2017

@xyalan Currently the fix is in v1.9 and master branch. Not available for v1.8.

@wojtek-t Shall we cherry-pick to v1.8?

@wojtek-t
Copy link
Member

wojtek-t commented Dec 2, 2017

@jpbetz is patch release manager for v1.8

@Bobi-zhou
Copy link

I have same problem in v1.8.4 too，how to fix it？

@dixudx
Copy link
Member Author

dixudx commented Dec 8, 2017

@xyalan @Bobi-zhou Sorry for the delay. I've already cherry-picked the fix to release-1.8. Please refer to #56945. The fix should be available in v1.8.6.

For current already-released v1.8 version, please cherry-pick the fix manually if you really need it and re-compile kubelet.

And v1.9 is coming out soon, targeted on Dec 13. You can wait for this new version, which has already included the fix.

@dixudx dixudx mentioned this issue Dec 11, 2017
Closed
@whereisaaron whereisaaron mentioned this issue Dec 18, 2017
Closed
@superseb superseb mentioned this issue Dec 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

falls back to parse Docker runtime version as generic if not semver dixudx/kubernetes
6 participants
@xyalan @dixudx @wojtek-t @Bobi-zhou @k8s-github-robot @k8s-ci-robot