Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admission config file for UAS can't handle embedded objects #54159

Closed
deads2k opened this issue Oct 18, 2017 · 4 comments
Closed

admission config file for UAS can't handle embedded objects #54159

deads2k opened this issue Oct 18, 2017 · 4 comments
Assignees
@deads2k
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
v1.9

Comments

@deads2k
Copy link
Contributor

deads2k commented Oct 18, 2017

The config objects contained don't round trip.
@deads2k deads2k added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. status/approved-for-milestone labels Oct 18, 2017
@deads2k deads2k added this to the v1.9 milestone Oct 18, 2017
@deads2k deads2k self-assigned this Oct 18, 2017
@deads2k deads2k mentioned this issue Oct 18, 2017
Merged
@deads2k deads2k added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Issue Current

@deads2k

Issue Labels
  • sig/api-machinery: Issue will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@lavalamp
Copy link
Member

I don't understand the description, can you expand a bit?

@mbohlool
Copy link
Contributor

cc @caesarxuchao

@deads2k
Copy link
Contributor Author

deads2k commented Oct 20, 2017

I don't understand the description, can you expand a bit?

Without a nested encoder and decoder for the embedded objects, decoding and re-encoding didn't serialize back out correctly. #53442 fixes the problem.

hh pushed a commit to ii/kubernetes that referenced this issue Oct 20, 2017
Merge pull request kubernetes#53442 from deads2k/server-02-nesteddeco…
0736c55 
…ding

Automatic merge from submit-queue (batch tested with PRs 53916, 53442). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add nested encoder and decoder to admission config

Fixes kubernetes#54159

Adds the required nested object encoder/decoder pairs for admission config extensions.

@sttts
sttts pushed a commit to sttts/apiserver that referenced this issue Oct 21, 2017
@k8s-publish-robot
Merge pull request #53442 from deads2k/server-02-nesteddecoding
205ba9a 
Automatic merge from submit-queue (batch tested with PRs 53916, 53442). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add nested encoder and decoder to admission config

Fixes kubernetes/kubernetes#54159

Adds the required nested object encoder/decoder pairs for admission config extensions.

@sttts

Kubernetes-commit: 0736c55776ad272731ff9c27aae2a2bbd010f3ee
sttts pushed a commit to sttts/apiserver that referenced this issue Oct 26, 2017
@k8s-publish-robot
Merge pull request #53442 from deads2k/server-02-nesteddecoding
c4aba92 
Automatic merge from submit-queue (batch tested with PRs 53916, 53442). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add nested encoder and decoder to admission config

Fixes kubernetes/kubernetes#54159

Adds the required nested object encoder/decoder pairs for admission config extensions.

@sttts

Kubernetes-commit: 0736c55776ad272731ff9c27aae2a2bbd010f3ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
v1.9
Development

No branches or pull requests
4 participants
@lavalamp @mbohlool @deads2k @k8s-github-robot