Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix azure storage account num exhausting issue #54459

Merged
merged 1 commit into from Oct 27, 2017
Merged

fix azure storage account num exhausting issue #54459

merged 1 commit into from Oct 27, 2017

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 24, 2017 •
edited

What this PR does / why we need it:
If customer is using the default storage class of azure-disk, create lots of azure disk pvs by using default storage class of azure-disk, the storage account num would be exhausted in the azure subscription. Change default kind value of azure disk storge class from Dedicated to Shared, which means only a few storage accounts would be created even there are even hundreds of azure disk PVs.

Which issue this PR fixes:
fixes #54669
fix storage account num exhausting issue when lots of azure disk pvs are created by using the default storage class of azure-disk

Special notes for your reviewer:
fix azure storage account num exhausting issue when lots of azure disk pvs are created by using the default storage class of azure-disk
I would suggest also cherry pick this fix to v1.7, v1.8

Release note:

none

/sig azure
@karataliu @rootfs @brendanburns

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/azure size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2017
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

rootfs
rootfs reviewed Oct 24, 2017
View reviewed changes
pkg/volume/azure_dd/azure_common.go Outdated
@@ -116,7 +116,7 @@ func normalizeFsType(fsType string) string {

func normalizeKind(kind string) (v1.AzureDataDiskKind, error) {
if kind == "" {
return v1.AzureDedicatedBlobDisk, nil
return v1.AzureSharedBlobDisk, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to make a const for default kind and add doc around the default

@andyzhangx
change default kind value of azure disk pv
9bcb82d 
make a const for default azure disk kind
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-test

@rootfs
Copy link
Contributor

rootfs commented Oct 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyzhangx, rootfs

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

rootfs added a commit to rootfs/origin that referenced this pull request Oct 26, 2017
@rootfs
UPSTREAM: 54459: kubernetes/kubernetes#54459
bfd9a3a 
Signed-off-by: Huamin Chen <hchen@redhat.com>
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53730, 51608, 54459, 54534, 54585). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d85fd8b into kubernetes:master Oct 27, 2017
This was referenced Oct 27, 2017
Closed
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 31, 2017
Merge pull request #54676 from andyzhangx/automated-cherry-pick-of-#5…
d95c56c 
…4459-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54459

Cherry pick of #54459 on release-1.8.

#54459: change default kind value of azure disk pv
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 2, 2017
@andyzhangx
Copy link
Member Author

/release-note-none

@andyzhangx andyzhangx deleted the azure-change-default-pv-kind branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs rootfs left review comments

Assignees

@justinsb justinsb

@rootfs rootfs

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure storage account num exhausting issue
6 participants
@andyzhangx @rootfs @k8s-github-robot @justinsb @saad-ali @k8s-ci-robot