Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #54184 #54520

Merged
merged 1 commit into from Oct 26, 2017
Merged

Automated cherry pick of #54184 #54520

merged 1 commit into from Oct 26, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 24, 2017 •
edited by jpbetz

Cherry pick of #54184 on release-1.8.

#54184: Fix retry logic in service controller

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 24, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 24, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

/assign @nicksardo

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, nicksardo

Associated issue: 54184

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

/unassign @thockin @matchstick
/assign @wojtek-t
for cherrypick approval.

@k8s-ci-robot k8s-ci-robot assigned wojtek-t and unassigned thockin and matchstick Oct 24, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

Oops, assigning the correct person...
/unassign @wojtek-t
/assign @jpbetz

@k8s-ci-robot k8s-ci-robot assigned jpbetz and unassigned wojtek-t Oct 24, 2017
@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 25, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit fcd8b7c into kubernetes:release-1.8 Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MrHohn @nicksardo @k8s-github-robot @jpbetz @thockin @wojtek-t @matchstick @k8s-ci-robot