Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a typo in dockershim.cm.containerManager.doWork #54528

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

yanxuean
Copy link
Contributor

Signed-off-by: yanxuean yan.xuean@zte.com.cn

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

/sig node

Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yanxuean. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2017
@xiangpengzhao
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2017
@yanxuean
Copy link
Contributor Author

/retest

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 4, 2017

/assign @yujuhong @Random-Liu
@yujuhong @Random-Liu ping for approve

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 4, 2017

/test pull-kubernetes-unit

1 similar comment
@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 4, 2017

/test pull-kubernetes-unit

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 4, 2017

/retest

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 8, 2017

/test pull-kubernetes-e2e-kops-aws

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 8, 2017

/retest

@yujuhong
Copy link
Contributor

yujuhong commented Nov 8, 2017

Correcting typos is good, but correcting more than one typo in a PR may make the review process more efficient(?).

/lgtm

@yujuhong
Copy link
Contributor

yujuhong commented Nov 9, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangpengzhao, yanxuean, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 9, 2017

Correcting typos is good, but correcting more than one typo in a PR may make the review process more efficient(?).

OK. I will do it as you said.
On that day I found the issue and send the pr immediately. It really waste out time.
Thanks:)

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 9, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53747, 54528, 55279, 55251, 55311). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f47a54e into kubernetes:master Nov 9, 2017
@yanxuean yanxuean deleted the ds-cm-typo branch November 9, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants