Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad url #55300

Merged
merged 1 commit into from
Nov 13, 2017
Merged

fix bad url #55300

merged 1 commit into from
Nov 13, 2017

Conversation

stewart-yu
Copy link
Contributor

What this PR does / why we need it:
The link url is bad, fix it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/design Categorizes issue or PR as related to design. kind/old-docs labels Nov 8, 2017
@thockin
Copy link
Member

thockin commented Nov 9, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stewart-yu, thockin

Associated issue requirement bypassed by: thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@stewart-yu
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@stewart-yu: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stewart-yu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Contributor

@stewart-yu: you can't request testing unless you are a kubernetes member.

In response to this:

/test pull-kubernetes-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Nov 9, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2017
@nikhita
Copy link
Member

nikhita commented Nov 9, 2017

@stewart-yu This PR needs to be opened against the master branch and not the release-1.7 branch.

@stewart-yu
Copy link
Contributor Author

This pr is to fix bad url in release-1.7 branch， does to be opened against the master branch? @nikhita

@nikhita
Copy link
Member

nikhita commented Nov 9, 2017

@stewart-yu Typically, when something needs to be merged into a previous release branch, a PR is created against the master first. Then it is cherry-picked to the release-1.7 branch, if the branch manager (@wojtek-t for 1.7) approves.

But like you said, it looks like the file does not exist on master in this case.

@wojtek-t What must be done here?

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 13, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Nov 13, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@nikhita
Copy link
Member

nikhita commented Nov 13, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit daecb0f into kubernetes:release-1.7 Nov 13, 2017
@stewart-yu stewart-yu deleted the fixurl branch November 14, 2017 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@stewart-yu @thockin @k8s-github-robot @k8s-ci-robot @nikhita @fejta-bot @smarterclayton @wojtek-t