Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cadvisor.New signature for cross build #56003

Merged
merged 1 commit into from
Nov 20, 2017
Merged

fix cadvisor.New signature for cross build #56003

merged 1 commit into from
Nov 20, 2017

Conversation

BenTheElder
Copy link
Member

What this PR does / why we need it: fixes the pkg/kubelet/cadvisor.New signature on non-linux platforms to match the new one on linux. This should fix the cross build

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56002

Special notes for your reviewer:

Release note:

NONE

/sig release

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2017
@BenTheElder
Copy link
Member Author

I'm not sure if the windows implementation should be using this new parameter, I think not.
/cc @dashpole

@BenTheElder
Copy link
Member Author

/retest

2 similar comments
@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

/retest

@dashpole
Copy link
Contributor

thanks for fixing this @BenTheElder

@dashpole
Copy link
Contributor

The windows implementation probably shouldn't use it. It can be used to optimize stats collection if the runtime is providing stats through the CRI Stats API.

dashpole
dashpole approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenTheElder
Copy link
Member Author

BenTheElder commented Nov 19, 2017 •
edited

/test pull-kubernetes-cross
🤞 (just moved to be on Prow)

@BenTheElder
Copy link
Member Author

/priority failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 19, 2017
@BenTheElder BenTheElder mentioned this pull request Nov 19, 2017
Closed
@erhudy erhudy mentioned this pull request Nov 19, 2017
Closed
@dims
Copy link
Member

dims commented Nov 19, 2017

/lgtm

we need this to get the cross ci job back on its feet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2017
@feiskyer
Copy link
Member

ping @derekwaynecarr for approval

@dixudx dixudx mentioned this pull request Nov 20, 2017
Closed
@dims dims mentioned this pull request Nov 20, 2017
Closed
@rootfs
Copy link
Contributor

rootfs commented Nov 20, 2017

are we going to have it today? code freezing this week ...

@BenTheElder
Copy link
Member Author

PTAL
/cc @yujuhong

@yujuhong
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2017
@yujuhong
Copy link
Contributor

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, yujuhong

Associated issue: 56002

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yujuhong yujuhong added this to the v1.9 milestone Nov 20, 2017
@yujuhong
Copy link
Contributor

/status approved-for-milestone

@k8s-ci-robot
Copy link
Contributor

You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to add status labels.

@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 20, 2017
@yujuhong yujuhong added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 20, 2017
@dashpole dashpole mentioned this pull request Nov 20, 2017
Closed
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@BenTheElder @derekwaynecarr @dims @resouer @yujuhong

Pull Request Labels
  • sig/node sig/release: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@dashpole
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 849d7f8 into kubernetes:master Nov 20, 2017
@dashpole dashpole mentioned this pull request Nov 20, 2017
Closed
@BenTheElder BenTheElder deleted the fix-cross-cadvisor branch November 20, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@dims dims

@resouer resouer

@derekwaynecarr derekwaynecarr

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

pull-kubernetes-cross is failing
10 participants
@BenTheElder @dashpole @dims @feiskyer @rootfs @yujuhong @k8s-github-robot @k8s-ci-robot @resouer @derekwaynecarr