Wait for controllerrevision informer to sync on statefulset controller startup

[tnozicka]

Fixes: #56355

Needs to be backported to at least 1.8, 1.9 and triaged for impact on 1.9 release

/cc @smarterclayton @kow3ns @enisoc

Release note:

NONE

[tnozicka]

/kind bug
/priority critical-urgent

[tnozicka]

/retest

[kow3ns]

/approve

[tnozicka]

/sig apps

[smarterclayton]

Serious issue for stateful set users and can result in large numbers of controller revisions created unexpectedly. Minor risk.

[tnozicka]

status: needs lgtm :)

[kow3ns]

@enisoc @foxish PTAL

[kow3ns]

@tnozicka I like to get a second review as apposed to lgtm and approve from the same person.

[janetkuo]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, kow3ns, tnozicka

Associated issue: 56355

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/controller/statefulset/OWNERS [janetkuo,kow3ns]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Current

@foxish @janetkuo @kow3ns @tnozicka

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

• sig/apps: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-ci-robot]

@tnozicka: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-unit	ba6ed64	link	/test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 56356, 56435). If you want to cherry-pick this change to another branch, please follow the instructions here.

[krmayankk]

@tnozicka @kow3ns @smarterclayton can this be also back ported to 1.7 ? We are seeing this issue as well and we just upgraded to 1.7. It would be nice to get this fix without upgrading to 1.8 or 1.9 . Also are there ways to avoid it ?

[tnozicka]

@krmayankk syncing informers should be there from the start so I would say backport to 1.7 should be ok but the likely offending PR with collision count #50490 isn't part of 1.7 I think. Without collision count it should fail on the controller revision already being created. It might be caused by something similar though.